[12.5.X] fix ClusterStorer::ClusterHitRecord<T>::rekey for Phase2TrackerRecHit1D

[mmusich]

This is a follow-up to #40395.
In the specialization of ClusterStorer::ClusterHitRecord<T>::rekey for VectorHits introduced there, I overlooked that VectorHit::ClusterRef and Phase2TrackerRecHit1D::ClusterRef are typedefs of the exact same object:

cmssw/DataFormats/TrackerRecHit2D/interface/Phase2TrackerRecHit1D.h

Line 13 in 8154525

typedef OmniClusterRef::Phase2Cluster1DRef ClusterRef;

cmssw/DataFormats/TrackerRecHit2D/interface/VectorHit.h

Line 30 in 8154525

typedef OmniClusterRef::Phase2Cluster1DRef ClusterRef;

This leads to the fact that when this function was called here:

cmssw/CommonTools/RecoAlgos/src/ClusterStorer.cc

Line 133 in 7661a79

it->template rekey<HitType>(newRef);

with Phase2TrackerRecHit1D::ClusterRef specialization, it didn't capture any cluster reference but was just returning:

cmssw/CommonTools/RecoAlgos/src/ClusterStorer.cc

Lines 198 to 200 in 7661a79

	} else {
	return;
	}

This leads to broken cluster reference for Phase2TrackerRecHit1D in Phase-2 workflows.

PR validation:

Run successfully:

  runTheMatrix.py --what upgrade -l 11634.0,20818.9,20834.0 -t 4 -j 8 --ibeos

and tested that I can correctly refit the resulting tracks with the machinery introduced at #40542.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #40548. Needed to backport all the way down to 12.5.X for phase-2 related samples productions.

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_5_X.

It involves the following packages:

• CommonTools/RecoAlgos (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@rappoccio, @missirol, @ahinzmann, @abbiendi, @jhgoh, @jdolen, @gkasieczka, @hatakeyamak this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from fix ClusterStorer::ClusterHitRecord<T>::rekey for Phase2TrackerRecHit1D #40548

[mmusich]

type bug-fix, tracking

[mmusich]

backport of #40548

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1be805/30071/summary.html
COMMIT: 2c515df
CMSSW: CMSSW_12_5_X_2023-01-15-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40559/30071/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3724047
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3724017
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 216 log files, 167 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1