Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RECONSTRUCTION] [CLANG] Fixes warnings reported by clang 14 #40516

Merged
merged 2 commits into from
Feb 7, 2023
Merged

[RECONSTRUCTION] [CLANG] Fixes warnings reported by clang 14 #40516

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d58d49b
[RECONSTRUCTION] [CLANG] Fixes warnings reported by clang 14
smuzaffar Jan 13, 2023
bb287eb
code cleanup: remove unnecessary code
smuzaffar Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions CommonTools/Utils/test/testExpressionParser.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,10 +264,9 @@ void testExpressionParser::checkAll() {
std::cout << "Check for leaks in the " << (b ? "Lazy" : "standard") << " string parser" << std::endl;
expr.reset();
reco::parser::expressionParser<pat::Muon>("triggerObjectMatchesByPath('HLT_Something').size()", expr, b);
double res = 0;
for (size_t i = 0; i < 10 * 1000; ++i) {
for (size_t j = 0; j < 100; ++j) {
res += expr->value(o);
expr->value(o);
break;
}
break;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this break, what is the purpose of the outer for loop?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also confused by this may be @VinInn can help here

Expand Down