[RECONSTRUCTION] [CLANG] Fixes warnings reported by clang 14 #40516

smuzaffar · 2023-01-13T16:05:55Z

This should fix the clang 14 warning. For now I have removed the unused res variable but if needed then I can just print out the res value so that compiler do not complain about unused variable.

cmsbuild · 2023-01-13T16:13:56Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40516/33715

This PR adds an extra 12KB to repository

cmsbuild · 2023-01-13T16:14:24Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

CommonTools/Utils (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2023-01-15T11:08:49Z

please test

cmsbuild · 2023-01-15T13:46:26Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b01d9a/29994/summary.html
COMMIT: d58d49b
CMSSW: CMSSW_13_0_X_2023-01-14-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40516/29994/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555538
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555510
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 211 log files, 162 edm output root files, 49 DQM output files
TriggerResults: no differences found

mandrenguyen · 2023-01-15T15:45:16Z

+reconstruction
Technical, no changes to reco

cmsbuild · 2023-01-15T15:45:44Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-01-15T18:14:17Z

CommonTools/Utils/test/testExpressionParser.cc

      for (size_t i = 0; i < 10 * 1000; ++i) {
        for (size_t j = 0; j < 100; ++j) {
-          res += expr->value(o);
+          expr->value(o);
          break;
        }
        break;


Given this break, what is the purpose of the outer for loop?

I was also confused by this may be @VinInn can help here

perrotta · 2023-01-18T10:00:16Z

@VinInn could you please comment about #40516 (review), so that we can conclude with this technical PR?

rappoccio · 2023-01-30T10:10:56Z

@VinInn ping about this review comment?

VinInn · 2023-01-30T10:36:44Z

Sorry: what I have to do with this? Not my code. and do not understand the two break either

smuzaffar · 2023-01-30T10:44:03Z

sorry @VinInn my bad , I mixed up ExpressionEvaluator (which is mostly developeed by you) and ExpressionParser.

perrotta · 2023-01-30T16:27:50Z

@smuzaffar so what should we do here?
Your PR fixes the clang warning, as intended. As such, I'd have no objections in merging it.
On the other hand, it pointegs to a test which apparently nobody can understand: is it testing anything, then?
If anyone knows or understands how was this test supposed to work, I'd preferably fix it. Otherwise, we can just merge it and forget afterwards.

smuzaffar · 2023-01-31T09:19:06Z

please test

cmsbuild · 2023-01-31T09:23:45Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40516/33951

This PR adds an extra 16KB to repository

cmsbuild · 2023-01-31T09:24:09Z

Pull request #40516 was updated. @mandrenguyen, @clacaputo can you please check and sign again.

cmsbuild · 2023-01-31T11:56:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b01d9a/30272/summary.html
COMMIT: bb287eb
CMSSW: CMSSW_13_0_X_2023-01-30-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40516/30272/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 4 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555495
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555473
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 211 log files, 162 edm output root files, 49 DQM output files
TriggerResults: no differences found

mandrenguyen · 2023-02-07T16:36:07Z

+reconstruction

cmsbuild · 2023-02-07T16:36:36Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-02-07T16:59:02Z

+1

[RECONSTRUCTION] [CLANG] Fixes warnings reported by clang 14

d58d49b

cmsbuild added this to the CMSSW_13_0_X milestone Jan 13, 2023

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jan 13, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 13, 2023

cmsbuild mentioned this pull request Jan 13, 2023

[RECO] [CLANG] More fixes on unused-but-set-variable warnings #40520

Merged

cmsbuild added tests-started and removed tests-pending labels Jan 15, 2023

cmsbuild added tests-approved and removed tests-started labels Jan 15, 2023

cmsbuild added fully-signed reconstruction-approved and removed reconstruction-pending pending-signatures labels Jan 15, 2023

perrotta reviewed Jan 15, 2023

View reviewed changes

code cleanup: remove unnecessary code

bb287eb

cmsbuild added code-checks-pending pending-signatures reconstruction-pending tests-started and removed reconstruction-approved fully-signed tests-approved code-checks-approved labels Jan 31, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 31, 2023

cmsbuild added tests-approved and removed tests-started labels Jan 31, 2023

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Feb 7, 2023

cmsbuild added orp-approved and removed orp-pending labels Feb 7, 2023

cmsbuild merged commit 98f96ea into cms-sw:master Feb 7, 2023

This was referenced Feb 7, 2023

[Tensorflow] Build with GPU enabled cms-sw/cmsdist#7648

Merged

Update Tensorflow to version 2.11.0 cms-sw/cmsdist#8258

Closed

[BuildRules] Enable alpaka/rocm backend and fix lto edm plugins cms-sw/cmsdist#8298

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RECONSTRUCTION] [CLANG] Fixes warnings reported by clang 14 #40516

[RECONSTRUCTION] [CLANG] Fixes warnings reported by clang 14 #40516

smuzaffar commented Jan 13, 2023

cmsbuild commented Jan 13, 2023

cmsbuild commented Jan 13, 2023

smuzaffar commented Jan 15, 2023

cmsbuild commented Jan 15, 2023

mandrenguyen commented Jan 15, 2023

cmsbuild commented Jan 15, 2023

perrotta Jan 15, 2023

smuzaffar Jan 15, 2023

perrotta commented Jan 18, 2023

rappoccio commented Jan 30, 2023

VinInn commented Jan 30, 2023

smuzaffar commented Jan 30, 2023

perrotta commented Jan 30, 2023

smuzaffar commented Jan 31, 2023

cmsbuild commented Jan 31, 2023

cmsbuild commented Jan 31, 2023

cmsbuild commented Jan 31, 2023

mandrenguyen commented Feb 7, 2023

cmsbuild commented Feb 7, 2023

perrotta commented Feb 7, 2023

[RECONSTRUCTION] [CLANG] Fixes warnings reported by clang 14 #40516

[RECONSTRUCTION] [CLANG] Fixes warnings reported by clang 14 #40516

Conversation

smuzaffar commented Jan 13, 2023

cmsbuild commented Jan 13, 2023

cmsbuild commented Jan 13, 2023

smuzaffar commented Jan 15, 2023

cmsbuild commented Jan 15, 2023

Comparison Summary

mandrenguyen commented Jan 15, 2023

cmsbuild commented Jan 15, 2023

perrotta Jan 15, 2023

Choose a reason for hiding this comment

smuzaffar Jan 15, 2023

Choose a reason for hiding this comment

perrotta commented Jan 18, 2023

rappoccio commented Jan 30, 2023

VinInn commented Jan 30, 2023

smuzaffar commented Jan 30, 2023

perrotta commented Jan 30, 2023

smuzaffar commented Jan 31, 2023

cmsbuild commented Jan 31, 2023

cmsbuild commented Jan 31, 2023

cmsbuild commented Jan 31, 2023

Comparison Summary

mandrenguyen commented Feb 7, 2023

cmsbuild commented Feb 7, 2023

perrotta commented Feb 7, 2023