Add iEta/iX, iPhi/iY to supercluster object

[swagata87]

PR description:

This is a continuation of #40327. As mentioned there, in this PR the variables iEta, iPhi, iX and iY are added directly to the Supercluster object, so that they can be accessed from AOD/miniAOD-based analysis setups in a more convenient, easy and user-friendly way.

PR validation:

Checked with workflow 2500.601

FYI @Sam-Harper

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40434/33575

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40434/33575/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40434/33575/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40434/33611

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

• DataFormats/EgammaReco (reconstruction)
• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @mandrenguyen, @clacaputo, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @Prasant1993, @rovere, @lgray, @missirol, @a-kapoor, @afiqaize, @gpetruc, @wrtabb, @sameasy, @varuns23, @sobhatta this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[swagata87]

enable nano

[swagata87]

enable profiling

[swagata87]

@cmsbuild please test

[swagata87]

type egamma

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9367b0/29838/summary.html
COMMIT: 49246a3
CMSSW: CMSSW_13_0_X_2023-01-09-1100/el8_amd64_gcc11
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40434/29838/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-01-09-1100/src/RecoParticleFlow/PFClusterTools/src/PFEnergyCalibration.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-01-09-1100/src/RecoParticleFlow/PFClusterTools/src/PFEnergyCalibrationHF.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-01-09-1100/src/RecoParticleFlow/PFClusterTools/src/PFEnergyResolution.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-01-09-1100/src/RecoParticleFlow/PFClusterTools/src/PFResolutionMap.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-01-09-1100/src/RecoParticleFlow/PFClusterTools/src/ClusterClusterMapping.cc: In static member function 'static bool ClusterClusterMapping::overlap(const reco::CaloCluster&, const reco::CaloCluster&, float, bool)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-01-09-1100/src/RecoParticleFlow/PFClusterTools/src/ClusterClusterMapping.cc:17:37: error: ambiguous overload for 'operator<<' (operand types are 'std::basic_ostream' and 'const DetId')
   17 |         std::cout << " Discarding " << hits1[i1].first << " with " << hits1[i1].second << std::endl;
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~
      |                   |
      |                   std::basic_ostream
In file included from /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02767/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/include/c++/11.2.1/iostream:39,


[vlimant]

looks like an error related to the IB @perrotta @rappoccio

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40434/33621

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #40434 was updated. @cmsbuild, @mandrenguyen, @clacaputo, @swertz, @vlimant can you please check and sign again.

[swagata87]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9367b0/29853/summary.html
COMMIT: 38517ba
CMSSW: CMSSW_13_0_X_2023-01-09-1100/el8_amd64_gcc11
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40434/29853/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 32 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555538
• DQMHistoTests: Total failures: 1214
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3554302
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[swertz]

+xpog

[mandrenguyen]

+reconstruction
Only spurious changes to comparisons from wf 11634 as described in issue #39803
Otherwise, this PR is a cleanup, simplifying access to kinematic variables of superclusters

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1