-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MkFit] Per iteration / eta region track candidate scoring function #40490
Conversation
…d eta region. Configure through standard function catalog and JSON files.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40490/33667
|
A new Pull Request was created by @osschar (Matevž Tadel) for master. It involves the following packages:
@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type tracking |
please test |
-1 Failed Tests: HeaderConsistency RelVals RelVals-INPUT AddOn RelVals
Expand to see more relval errors ...RelVals-INPUT
Expand to see more relval errors ...AddOn Tests
Expand to see more addon errors ... |
Sigh, I wrongly assumed JSON parser wouldn't mind the missing members ... that they would just keep the default values. I apologize for the omission and noise. |
I have added the JSON changes: cms-data/RecoTracker-MkFit#11 |
test parameters: |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40490/33687
|
Thanks @smuzaffar ... I added the include. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40490/33735
|
Pull request #40490 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again. |
@cmsbuild please test the differences are now understood and no further changes are planned to this PR, unless some are requested in the review |
For completeness:
As the above-mentioned slight differences are related to compilation and not to the actual changes introduced by this PR, we would consider the PR itself validated in terms of performance. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e223d6/30100/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
+reconstruction |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
Allow track/candidate scoring function to be defined per iteration and eta region.
Configure through standard function catalog and JSON files.
Default is to pick the existing scoring function so there is no need to provide new JSON files until new scoring functions are actually implemented.
Definitions of function types used in standard function catalogs are moved from MkFitCore/interface/IterationConfig.h to FunctionTypes.h
The purpose of this PR is to allow further work on improvements of MKFit performance.
PR validation:
This is a technical change, there should be no changes in physics performance.