Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 12_6_X (1/N) [13_0_X] #40220

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Dec 2, 2022

PR description:

Development of HLT menus for CMSSW_12_6_X.

This is the PR for the master branch, which will then be backported to 12_6_X (the latter is now the release cycle used for HLT-menu development for Run 3; the development of HLT menus in 12_5_X has come to a close).

This PR includes the integration of the following JIRA tickets.

  • CMSHLT-2510: [TSG] set MessageLogger.cerr.enableStatistics = False
  • CMSHLT-2579: [HIN] use EvFFEDExcluder for rawPrimeDataRepacker
  • CMSHLT-2582: [TSG] add hltOnlineMetaDataDigis to DQMHistograms EndPath
  • CMSHLT-2585: [TK-DPG] rename PixelCPEFastESProducer to hltESPPixelCPEFast

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_12_6_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40220/33259

  • This PR adds an extra 908KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

missirol commented Dec 2, 2022

enable gpu

@missirol
Copy link
Contributor Author

missirol commented Dec 2, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6cdf1c/29417/summary.html
COMMIT: 6988a95
CMSSW: CMSSW_13_0_X_2022-12-01-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40220/29417/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421150
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3421125
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.002 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 7.3,... ): -0.001 KiB HLT/Filters
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19934
  • DQMHistoTests: Total failures: 605
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19329
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

missirol commented Dec 2, 2022

+hlt

  • differences in outputs of PR tests are as expected (no physics changes, only changes due to new names of the HLT menus)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@missirol
Copy link
Contributor Author

missirol commented Dec 2, 2022

@cms-sw/orp-l2

(just to be extra clear)

This PR can proceed, it must be merged before #40215 (or in the same IB).

@perrotta
Copy link
Contributor

perrotta commented Dec 2, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants