Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_6_X] update input dataset and fix step #40184

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

vlimant
Copy link
Contributor

@vlimant vlimant commented Nov 30, 2022

PR description:

a couple of fixes to the nano workflows

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 30, 2022

A new Pull Request was created by @vlimant (vlimant) for CMSSW_12_6_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@vlimant
Copy link
Contributor Author

vlimant commented Nov 30, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9b674/29355/summary.html
COMMIT: c884502
CMSSW: CMSSW_12_6_X_2022-11-30-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40184/29355/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 2500.601 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1393 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3416693
  • DQMHistoTests: Total failures: 303
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3416368
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 43.164 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 2500.601 ): 43.164 KiB Physics/NanoAODDQM
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@vlimant
Copy link
Contributor Author

vlimant commented Dec 1, 2022

lots of changes since the input dataset was changed

@vlimant
Copy link
Contributor Author

vlimant commented Dec 1, 2022

+1

@vlimant
Copy link
Contributor Author

vlimant commented Dec 1, 2022

another signature from you please @cms-sw/pdmv-l2 @cms-sw/upgrade-l2

@sunilUIET
Copy link
Contributor

+pdmv

@AdrianoDee
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Dec 1, 2022

backport of #40211

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bbf25a7 into cms-sw:CMSSW_12_6_X Dec 1, 2022
@vlimant vlimant deleted the update_NANO_matrix branch December 4, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants