Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EDM inputs to HLT-Validation tests [10_2_X only] #40028

Merged
merged 2 commits into from
Nov 25, 2022
Merged

Update EDM inputs to HLT-Validation tests [10_2_X only] #40028

merged 2 commits into from
Nov 25, 2022

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Nov 9, 2022 •
edited
Loading

PR description:

This PR is specific to the CMSSW_10_2_X release cycle.

Some of the HLT-Validation tests running in IBs started to fail due to the unavailability of EDM files used as input to these tests (see IB dashboard, and #40013).

This PR updates the path to these files, to use copies kept in the TSG area on EOS. which will now rely on the cms-bot cache (see discussion in #40013 and #40020, where the corresponding updates to cms-bot are also mentioned).

In addition, it disables the HLT-integration-tests part of the HLT-Validation tests for scram-archs in SLC6, which are incompatible with the most recent version of ConfDB-v2 (see #40013 (comment)).

PR validation:

None.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

N/A

@cmsbuild cmsbuild added this to the CMSSW_10_2_X milestone Nov 9, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_10_2_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)
  • Utilities/ReleaseScripts (core)

@Martin-Grunewald, @Dr15Jones, @smuzaffar, @makortel, @cmsbuild, @missirol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

missirol commented Nov 9, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-470f46/28915/summary.html
COMMIT: 688c32d
CMSSW: CMSSW_10_2_X_2022-11-06-0000/slc6_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40028/28915/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007546
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007354
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 28 edm output root files, 31 DQM output files
  • TriggerResults: no differences found

@missirol missirol mentioned this pull request Nov 22, 2022
Closed
@missirol missirol force-pushed the fixHLTValTests_102X branch from 688c32d to b6d2b06 Compare November 23, 2022 18:11
@cmsbuild
Copy link
Contributor

Pull request #40028 was updated. @Martin-Grunewald, @Dr15Jones, @smuzaffar, @makortel, @cmsbuild, @missirol can you please check and sign again.

@missirol
Copy link
Contributor Author

please test

See #40030 (comment).

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-470f46/29215/summary.html
COMMIT: b6d2b06
CMSSW: CMSSW_10_2_X_2022-11-20-2300/slc6_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40028/29215/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007546
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007354
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 28 edm output root files, 31 DQM output files
  • TriggerResults: no differences found

@missirol
Skip HLT-integration tests in SLC6
d5fff49 
HLT-integration tests cannot run with SLC6 architectures,
due to an incompatibility with the latest .jar files of ConfDB-v2.
For further details, see cms-sw#40013 (comment)
@cmsbuild
Copy link
Contributor

Pull request #40028 was updated. @Martin-Grunewald, @Dr15Jones, @smuzaffar, @makortel, @cmsbuild, @missirol can you please check and sign again.

@missirol
Copy link
Contributor Author

please test

See #40013 (comment).

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-470f46/29232/summary.html
COMMIT: d5fff49
CMSSW: CMSSW_10_2_X_2022-11-20-2300/slc6_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40028/29232/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007546
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007351
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 28 edm output root files, 31 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

This PR fixes the HLT-Val tests currently failing in 10_2_X IBs (access EDM files from cms-bot cache + disable HLT-integration tests in SLC6).

The update of 1 input file of the addOnTests requires the signature of @cms-sw/core-l2 .

This was referenced Nov 25, 2022
Merged
Merged
@smuzaffar
Copy link
Contributor

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 828fa98 into cms-sw:CMSSW_10_2_X Nov 25, 2022
@missirol missirol deleted the fixHLTValTests_102X branch November 30, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core-approved fully-signed hlt-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_10_2_X
Development

Successfully merging this pull request may close these issues.
4 participants
@missirol @cmsbuild @smuzaffar @perrotta