-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.5.X] EMTF DQM fix to remove duplicate x-axis bin labels #39957
Conversation
backport of #39952 |
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_5_X. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
@cmsbuild, please test |
urgent
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f33f54/28733/summary.html Comparison SummarySummary:
|
histo differences not related to this PR |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
resolves #39936
PR description:
Changed DQM plot neighbor labels to avoid duplicates. This meant relabeling DQM plots such as cscDQMOccupancy among others. Chambers with the label "N" became labeled "N1", "N2" ... depending on which sector they preceded.
Change implemented in response to #39936, in which it was discovered that histogram merging is dependent on bin labels in newer ROOT versions, and therefore cannot be duplicate (#25569)
The flag gemChamberBXVFAT.CanExtend was also set to false for consistency with other plots.
PR validation:
First, the issue outlined in #39936 was recreated using the PSet in /afs/cern.ch/user/c/cmst0/public/PausedJobs/HIReplay2022/job_244/job/WMTaskSpace/cmsRun1. Then, the plot labels were changed and new DQMIO files were made with DQMRootOutputModule. These files substituted the input files used in #39936 and the merge was successful.
ROOT files were also created using DQMFileSaverPB to view the plots and ensure that the labels were correct.
This change will also be backported to release CMSSW_12_5_X and 12_5_1_patch1,
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
backport of #39952