-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EMTF DQM fix to remove duplicate x-axis bin labels #39952
EMTF DQM fix to remove duplicate x-axis bin labels #39952
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39952/32881
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
77d0f7a
to
d491976
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39952/32882
|
A new Pull Request was created by @nickh2000 for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type bug-fix |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bce884/28718/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@nickh2000 can you kindly prepare also a backport to 12_5_X for this PR? |
to speed up the procedure, I've taken the liberty to open #39952 |
+1 |
PR description:
Changed DQM plot neighbor labels to avoid duplicates. This meant relabeling DQM plots such as cscDQMOccupancy among others. Chambers with the label "N" became labeled "N1", "N2" ... depending on which sector they preceded.
Change implemented in response to #39936, in which it was discovered that histogram merging is dependent on bin labels in newer ROOT versions, and therefore cannot be duplicate (#25569)
The flag gemChamberBXVFAT.CanExtend was also set to false for consistency with other plots.
PR validation:
First, the issue outlined in #39936 was recreated using the PSet in /afs/cern.ch/user/c/cmst0/public/PausedJobs/HIReplay2022/job_244/job/WMTaskSpace/cmsRun1. Then, the plot labels were changed and new DQMIO files were made with DQMRootOutputModule. These files substituted the input files used in #39936 and the merge was successful.
ROOT files were also created using DQMFileSaverPB to view the plots and ensure that the labels were correct.
This change will also be backported to release CMSSW_12_5_X and 12_5_1_patch1,