Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark alpaka trait constants as inline [12.5.x] #39827

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Oct 23, 2022

PR description:

Mark trait constants as inline, and simplify the definition of the trait types.

Fixes #39786.

PR validation:

GCC 11 now generates unique global symbols (u) instead of local data symbols (b) for the allocators:

/data/user/fwyzard/gcc11/CMSSW_12_6_0_pre3/src$ nm -C ../lib/el8_amd64_gcc11/libHeterogeneousCoreAlpakaServicesCudaAsync.so | egrep 'allocator$'
0000000000016400 u guard variable for cms::alpakatools::getHostCachingAllocator<alpaka::uniform_cuda_hip::detail::QueueUniformCudaHipRt<alpaka::ApiCudaRt, false>, void>()::allocator
0000000000016420 u cms::alpakatools::getHostCachingAllocator<alpaka::uniform_cuda_hip::detail::QueueUniformCudaHipRt<alpaka::ApiCudaRt, false>, void>()::allocator

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #39826 to CMSSW_12_5_X to ease the migration to Alpaka.

Mark trait constants as inline, and simplify the definition of the trait
types.
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 23, 2022

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_5_X.

It involves the following packages:

  • HeterogeneousCore/AlpakaInterface (heterogeneous)

@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 23, 2022

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 23, 2022

backport #39826

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 23, 2022

+heterogeneous

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 23, 2022

please test

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f220c/28442/summary.html
COMMIT: 4bb0968
CMSSW: CMSSW_12_5_X_2022-10-22-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39827/28442/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3697216
  • DQMHistoTests: Total failures: 1004
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3696190
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

  • Merged in master
  • HeterogeneousCore/MPICore unit test failure in el8_ppc64le_gcc10 looks unrelated, as it appeared (from time to time in non-production architectures) even before #39826 was merged

@perrotta
Copy link
Contributor

merge

  • test-das-selected-lumis unit test error comes from DAS

@cmsbuild cmsbuild merged commit d90168a into cms-sw:CMSSW_12_5_X Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants