Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark alpaka trait constants as inline #39826

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Oct 23, 2022

PR description:

Mark trait constants as inline, and simplify the definition of the trait types.

Fixes #39786.

PR validation:

GCC 11 now generates unique global symbols (u) instead of local data symbols (b) for the allocators:

/data/user/fwyzard/gcc11/CMSSW_12_6_0_pre3/src$ nm -C ../lib/el8_amd64_gcc11/libHeterogeneousCoreAlpakaServicesCudaAsync.so | egrep 'allocator$'
0000000000016400 u guard variable for cms::alpakatools::getHostCachingAllocator<alpaka::uniform_cuda_hip::detail::QueueUniformCudaHipRt<alpaka::ApiCudaRt, false>, void>()::allocator
0000000000016420 u cms::alpakatools::getHostCachingAllocator<alpaka::uniform_cuda_hip::detail::QueueUniformCudaHipRt<alpaka::ApiCudaRt, false>, void>()::allocator

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to CMSSW_12_5_X to ease the migration to Alpaka.

Mark trait constants as inline, and simplify the definition of the trait
types.
@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 23, 2022

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 23, 2022

+heterogeneous

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 23, 2022

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 23, 2022

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 23, 2022

please test for el8_amd64_gcc11

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39826/32699

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

  • HeterogeneousCore/AlpakaInterface (heterogeneous)

can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-893997/28443/summary.html
COMMIT: 4bb0968
CMSSW: CMSSW_12_6_X_2022-10-22-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39826/28443/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6070 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3378384
  • DQMHistoTests: Total failures: 33068
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3345292
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 201 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

merge
(unit test error looks unrelated)

@cmsbuild cmsbuild merged commit 1cb04e7 into cms-sw:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two instances of a function-local static variable on gcc11
3 participants