-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark alpaka trait constants as inline #39826
Conversation
Mark trait constants as inline, and simplify the definition of the trait types.
type bugfix |
+heterogeneous |
enable gpu |
please test |
please test for el8_amd64_gcc11 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39826/32699
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages:
can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test test-das-selected-lumis had ERRORS Comparison SummarySummary:
|
+1 |
merge |
PR description:
Mark trait constants as inline, and simplify the definition of the trait types.
Fixes #39786.
PR validation:
GCC 11 now generates unique global symbols (
u
) instead of local data symbols (b
) for the allocators:If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
To be backported to CMSSW_12_5_X to ease the migration to Alpaka.