Update trigger filters for jets stored in Nano for Run3 menu #39818

johnalison · 2022-10-21T15:46:44Z

PR description:

Updating the Jet Trigger objects stored in Nano with the filters from the Run3 menu
Expect the trigObj content of the Nano to change.

PR validation:

Tested producing new NanoAOD in 12_4_8

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Would be good to have this in 12_4_X for Run3 Nano production.

cmsbuild · 2022-10-21T16:08:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39818/32686

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/triggerObjects_cff.py modified in PR(s): NANO configuration Cleanup #39796, Adding photon and muon leg trigger filters of HLT_Mu17_Photon30_IsoCa… #39309

cmsbuild · 2022-10-21T16:09:27Z

A new Pull Request was created by @johnalison (John Alison) for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

johnalison · 2022-10-21T16:34:52Z

The changes to PhysicsTools/NanoAOD/python/triggerObjects_cff.py modified in PR(s): #39796, #39309

can be merged with the changes proposed here.

swertz · 2022-10-27T08:36:38Z

Hi @johnalison , for my information, I suppose this change is not compatible with Run2 samples/triggers?

We are planning to change the way trigger object info is stored in nano, but for now we have decided that we would allow changes to the trigger object filter names necessary for Run3 so that prompt nano can pick those up, even if it breaks compatibility with Run2 or existing V10 samples.

Can you please apply the same changes to the "frozen" V10 config, so that V10 stay in sync between 124X and 126X? https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/V10/triggerObjects_cff.py

johnalison · 2022-10-27T13:17:47Z

@swertz correct. I have removed the filters that are not Run 3 and added filters that are not in Run-2.
yes, I can also update v10.triggerObjects_cff.py

johnalison · 2022-10-28T14:25:07Z

@swertz changes now in V10 config

cmsbuild · 2022-10-28T14:30:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39818/32820

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/V10/triggerObjects_cff.py modified in PR(s): NANO configuration Cleanup #39796
- File PhysicsTools/NanoAOD/python/triggerObjects_cff.py modified in PR(s): NANO configuration Cleanup #39796, Adding photon and muon leg trigger filters of HLT_Mu17_Photon30_IsoCa… #39309

cmsbuild · 2022-10-28T14:30:27Z

Pull request #39818 was updated. @cmsbuild, @swertz, @vlimant can you please check and sign again.

swertz · 2022-10-28T14:46:24Z

enable nano
please test

vlimant · 2022-10-31T09:23:37Z

please test

cmsbuild · 2022-10-31T12:49:11Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dce978/28660/summary.html
COMMIT: dffbc60
CMSSW: CMSSW_12_6_X_2022-10-30-2300/el8_amd64_gcc10
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39818/28660/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3416356
DQMHistoTests: Total failures: 157
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3416177
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 206 log files, 48 edm output root files, 48 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.001_data80X+MuonEG2016HMINIAOD8.0+NANO_data8.0+HRV_NANO_data
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.0_mc80X+TTbarMINIAOD8.0+NANO_mc8.0+HRV_NANO_mc
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.101_mc94Xv2+TTbarMINIAOD9.4v2+NANO_mc9.4v2+HRV_NANO_mc
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.11_data94X2016+MuonEG2016MINIAOD9.4v2+NANO_2016data9.4v2+HRV_NANO_data
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.12_data94Xv2+MuonEG2017MINIAOD9.4v2+NANO_data9.4v2+HRV_NANO_data
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.1_mc94X2016+TTbar2016MINIAOD9.4v2+NANO_2016mc9.4v2+HRV_NANO_mc
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.21_data102X+MuonEG2018MINIAOD10.2+NANO_data10.2+HRV_NANO_data
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.2_mc102X+TTbarMINIAOD10.2+NANO_mc10.2+HRV_NANO_mc
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.301_mc106Xul17+TTbarMINIAOD10.6_UL17v1+NANO_mc10.6ul17v1+HRV_NANO_mc
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.302_mc106Xul18+TTbarMINIAOD10.6_UL18v1+NANO_mc10.6ul18v1+HRV_NANO_mc
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.311_mc106Xul17v2+TTbarMINIAOD10.6_UL17v2+NANO_mc10.6ul17v2+HRV_NANO_mc
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.312_mc106Xul17v2+TTbarMINIAOD10.6_UL18v2+NANO_mc10.6ul18v2+HRV_NANO_mc
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.31_mc106Xul17v2+TTbarMINIAOD10.6_UL16v2+NANO_mc10.6ul16v2+HRV_NANO_mc
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.321_data106Xul17+MuonEG2017MINIAOD10.6v1+NANO_data10.6ul17v1+HRV_NANO_data
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.322_data106Xul18+MuonEG2018MINIAOD10.6v1+NANO_data10.6ul18v1+HRV_NANO_data
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.32_data106Xul16+MuonEG2016MINIAOD10.6v1+NANO_data10.6ul16v1+HRV_NANO_data
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.331_data106Xul17v2+MuonEG2017MINIAOD10.6v2+NANO_data10.6ul17v2+HRV_NANO_data
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.332_data106Xul18v2+MuonEG2018MINIAOD10.6v2+NANO_data10.6ul18v2+HRV_NANO_data
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.33_data106Xul16v2+MuonEG2016MINIAOD10.6v2+NANO_data10.6ul16v2+HRV_NANO_data
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.3_mc106Xul16+TTbarMINIAOD10.6_UL16v1+NANO_mc10.6ul16v1+HRV_NANO_mc
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.401_mc122Xrun3+TTbarMINIAOD12.2+NANO_mc12.2+HRV_NANO_mc
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.4_mc122Xrun3_v10+TTbarMINIAOD12.2+NANO_mc12.2_v10+HRV_NANO_mc
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.501_mc124Xrun3+TTbarMINIAOD12.4+NANO_mc12.4+HRV_NANO_mc
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.511_data124Xrun3+MuonEG2022MINIAOD12.4+NANO_data12.4+HRV_NANO_data
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.51_data124Xrun3_v10+MuonEG2022MINIAOD12.4+NANO_data12.4_v10+HRV_NANO_data
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.5_mc124Xrun3_v10+TTbarMINIAOD12.4+NANO_mc12.4_v10+HRV_NANO_mc
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce978/2500.6_mc126X_v10+TTBarMINIAOD12.6+NANO_mc12.6_v10+HRV_NANO_mc

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 29
DQMHistoTests: Total histograms compared: 28879
DQMHistoTests: Total failures: 572
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 28307
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
Checked 66 log files, 0 edm output root files, 29 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.140	2.168	-0.028 ( -1.3% )	7.09	6.99	+1.4%	1.377	1.385
2500.001	1.119	1.127	-0.008 ( -0.7% )	10.27	9.77	+5.1%	1.372	1.351
2500.1	2.267	2.295	-0.027 ( -1.2% )	5.38	5.30	+1.5%	1.733	1.742
2500.101	2.351	2.349	0.001 ( +0.1% )	4.47	4.50	-0.5%	1.904	1.889
2500.11	1.212	1.219	-0.007 ( -0.6% )	8.32	8.13	+2.3%	1.578	1.562
2500.12	1.318	1.318	0.000 ( +0.0% )	6.06	6.08	-0.2%	1.839	1.774
2500.2	2.194	2.192	0.003 ( +0.1% )	5.28	5.30	-0.2%	1.879	1.873
2500.21	1.210	1.208	0.002 ( +0.1% )	7.76	7.71	+0.7%	1.833	1.781
2500.3	2.312	2.350	-0.038 ( -1.6% )	5.16	5.09	+1.5%	1.731	1.714
2500.301	2.459	2.458	0.001 ( +0.1% )	4.68	4.63	+1.0%	1.491	1.489
2500.302	2.412	2.408	0.004 ( +0.1% )	4.80	4.73	+1.6%	1.796	1.780
2500.31	2.206	2.235	-0.030 ( -1.3% )	8.88	8.73	+1.7%	1.453	1.480
2500.311	2.327	2.325	0.002 ( +0.1% )	8.32	8.21	+1.3%	1.846	1.829
2500.312	2.278	2.275	0.003 ( +0.1% )	8.54	8.41	+1.6%	1.838	1.819
2500.32	1.081	1.086	-0.004 ( -0.4% )	8.96	8.92	+0.4%	1.591	1.575
2500.321	1.454	1.454	0.000 ( +0.0% )	6.00	5.95	+0.7%	1.777	1.776
2500.322	1.227	1.226	0.002 ( +0.1% )	7.45	7.52	-1.0%	1.495	1.498
2500.33	1.095	1.100	-0.005 ( -0.4% )	19.73	20.14	-2.0%	1.467	1.464
2500.331	1.390	1.390	0.000 ( +0.0% )	14.67	14.61	+0.5%	1.627	1.628
2500.332	1.322	1.316	0.005 ( +0.4% )	16.53	16.49	+0.2%	1.558	1.559
2500.4	2.115	2.112	0.003 ( +0.2% )	9.78	9.72	+0.6%	1.298	1.375
2500.401	2.115	2.112	0.003 ( +0.2% )	9.80	9.81	-0.2%	1.345	1.417
2500.5	0.302	0.302	0.000 ( +0.0% )	49.92	49.96	-0.1%	1.045	1.044
2500.501	0.302	0.302	0.000 ( +0.0% )	49.53	50.58	-2.1%	1.204	1.202
2500.51	1.098	1.080	0.018 ( +1.6% )	27.48	28.11	-2.2%	1.305	1.301
2500.511	1.098	1.080	0.018 ( +1.6% )	28.37	28.07	+1.1%	1.352	1.306
2500.6	1.417	1.371	0.047 ( +3.4% )	23.64	23.52	+0.5%	1.066	1.018
2500.601	1.418	1.371	0.047 ( +3.4% )	23.59	23.94	-1.5%	1.091	1.094

swertz · 2022-10-31T13:02:08Z

+1

Only differences are seen in jet trigger objects.

cmsbuild · 2022-10-31T13:02:32Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2022-10-31T16:41:58Z

+1

Changes expected in nano

Update trigger filters for jets stored in Nano for Run3 menu

9be4254

cmsbuild added this to the CMSSW_12_6_X milestone Oct 21, 2022

cmsbuild added code-checks-pending orp-pending pending-signatures tests-pending xpog-pending labels Oct 21, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 21, 2022

cmsbuild mentioned this pull request Oct 21, 2022

NANO configuration Cleanup #39796

Merged

3 tasks

johnalison mentioned this pull request Oct 26, 2022

Update trigger filters for jets stored in Nano for Run3 menu #39862

Merged

swertz mentioned this pull request Oct 28, 2022

Nano: fix matching between pat trigger objects and L1 objects #39893

Merged

Porting Run3 chages to V10/triggerObjects_cff.py

dffbc60

cmsbuild added code-checks-pending and removed code-checks-approved labels Oct 28, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 28, 2022

cmsbuild mentioned this pull request Oct 30, 2022

updating triggerObjects_cff V10 #39929

Merged

cmsbuild added tests-started and removed tests-pending labels Oct 31, 2022

cmsbuild added tests-approved and removed tests-started labels Oct 31, 2022

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Oct 31, 2022

cmsbuild added orp-approved and removed orp-pending labels Oct 31, 2022

cmsbuild merged commit 8a3aba2 into cms-sw:master Oct 31, 2022

This was referenced Oct 31, 2022

[MkFit] Phase2 geometry & String configurable standard functions #39866

Merged

Introduction of New-All-In-One tool for Offline Validation of TrkAlignment #38304

Merged

swertz added a commit to swertz/cmssw that referenced this pull request Dec 8, 2022

put back Run2 jet trigger object filters removed in cms-sw#39818

49659f1

swertz added a commit to swertz/cmssw that referenced this pull request Dec 9, 2022

put back Run2 jet trigger object filters removed in cms-sw#39818

93b7213

swertz added a commit to swertz/cmssw that referenced this pull request Dec 9, 2022

put back Run2 jet trigger object filters removed in cms-sw#39818

a8c09b4

swertz mentioned this pull request Dec 15, 2022

Nano: drop frozen V10 config, make triggerObjectTable more easily customizable #40321

Merged

swertz added a commit to swertz/cmssw that referenced this pull request Dec 20, 2022

put back Run2 jet trigger object filters removed in cms-sw#39818

4eb7450

NJManganelli pushed a commit to NJManganelli/cmssw that referenced this pull request Feb 24, 2023

put back Run2 jet trigger object filters removed in cms-sw#39818

9c80d83

aloeliger pushed a commit to aloeliger/cmssw that referenced this pull request Feb 24, 2023

put back Run2 jet trigger object filters removed in cms-sw#39818

bd72aec

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update trigger filters for jets stored in Nano for Run3 menu #39818

Update trigger filters for jets stored in Nano for Run3 menu #39818

johnalison commented Oct 21, 2022

cmsbuild commented Oct 21, 2022

cmsbuild commented Oct 21, 2022

johnalison commented Oct 21, 2022

swertz commented Oct 27, 2022

johnalison commented Oct 27, 2022

johnalison commented Oct 28, 2022

cmsbuild commented Oct 28, 2022

cmsbuild commented Oct 28, 2022

swertz commented Oct 28, 2022

vlimant commented Oct 31, 2022

cmsbuild commented Oct 31, 2022

swertz commented Oct 31, 2022

cmsbuild commented Oct 31, 2022

rappoccio commented Oct 31, 2022

Update trigger filters for jets stored in Nano for Run3 menu #39818

Update trigger filters for jets stored in Nano for Run3 menu #39818

Conversation

johnalison commented Oct 21, 2022

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Oct 21, 2022

cmsbuild commented Oct 21, 2022

johnalison commented Oct 21, 2022

swertz commented Oct 27, 2022

johnalison commented Oct 27, 2022

johnalison commented Oct 28, 2022

cmsbuild commented Oct 28, 2022

cmsbuild commented Oct 28, 2022

swertz commented Oct 28, 2022

vlimant commented Oct 31, 2022

cmsbuild commented Oct 31, 2022

Comparison Summary

NANO Comparison Summary

swertz commented Oct 31, 2022

cmsbuild commented Oct 31, 2022

rappoccio commented Oct 31, 2022