Add Eta cut to HLT Egamma objects - BackportFrom126X to 124X

[arsahasransu]

PR description:

• Added a module to do eta filtering of HLT Egamma objects
• Necessary for an eta cut on objects in the trigger HLT_DiPhoton10Time1p2ns_v

PR validation:

• Checked the functionality of the filter module and verified that the eta cuts function as intended. A basic plot is shown below.
• The red histogram is after the eta cut while the blue histogram is before cut. An |eta|<2.15 has been applied as can be observed by comparing the plots.
• Code checks and code format performed
• Based on advice from @Martin-Grunewald on a similar PR at Added a module to do eta filtering for Egamma HLT candidates #39764, it was decided to change the HLTEgammaEtFilter class in place of adding a new class.

PR backport:

• PR needs to be backported to CMSSW_12_4_X and 12_5_X.
• Original PR: Add Eta cut to HLT Egamma objects. #39789
• Also backport of Add Eta cut to HLT Egamma objects - BackportFrom126X to 125X #39792 in 125X
• The current software at HLT is in the 12_4_X release. Hence the need for backporting to 12_4_X.

[cmsbuild]

A new Pull Request was created by @arsahasransu (A.R.Sahasransu) for CMSSW_12_4_X.

It involves the following packages:

• HLTrigger/Egamma (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Add Eta cut to HLT Egamma objects. #39789

[arsahasransu]

backport of #39789

[missirol]

backport of #39789

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9f3a59/28400/summary.html
COMMIT: 00d79e3
CMSSW: CMSSW_12_4_X_2022-10-20-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39791/28400/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3675164
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3675134
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1