Add Eta cut to HLT Egamma objects.

[arsahasransu]

PR description:

• Added a module to do eta filtering of HLT Egamma objects
• Necessary for an eta cut on objects in the trigger HLT_DiPhoton10Time1p2ns_v

PR validation:

• Checked the functionality of the filter module and verified that the eta cuts function as intended. A basic plot is shown below.
• The red histogram is after the eta cut while the blue histogram is before cut. An |eta|<2.15 has been applied as can be observed by comparing the plots.
• Code checks and code format performed
• Based on advice from @Martin-Grunewald on a similar PR at Added a module to do eta filtering for Egamma HLT candidates #39764, it was decided to change the HLTEgammaEtFilter class in place of adding a new class.

PR backport:

• PR needs to be backported to CMSSW_12_4_X and 12_5_X
• The current software at HLT is in the 12_4_X release. Hence the need for backport.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39789/32658

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @arsahasransu (A.R.Sahasransu) for master.

It involves the following packages:

• HLTrigger/Egamma (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[missirol]

please test

Now the name of the plugin will be somewhat inaccurate (not just a EtFilter anymore). I assume it is not a problem, but I tag @swagata87 , in case she has comments.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39789/32660

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #39789 was updated. @Martin-Grunewald, @missirol can you please check and sign again.

[swagata87]

Hello Abanti,

As such I also do not see any problem in doing it this way.
But I was wondering if you have explored the alternative way of changing the eta cut at the HLT configuration level..
For example, have you tried to change the endcap_end parameter in your HLT path, as shown below?

[arsahasransu]

Hello Abanti,

As such I also do not see any problem in doing it this way. But I was wondering if you have explored the alternative way of changing the eta cut at the HLT configuration level.. For example, have you tried to change the endcap_end parameter in your HLT path, as shown below?

@swagata87 I did not think about this approach until you suggested it right now. I think that would work as well. Thanks for the suggestion. If that works, should I drop this PR and it's backports?

[swagata87]

One thing is that the approach I suggested can work only for L1Seeded leg. In case you wanted an eta cut also on the unseeded leg, then you might need this PR and do it your way.

[arsahasransu]

One thing is that the approach I suggested can work only for the L1Seeded leg. In case you wanted an eta cut also on the unseeded leg, then you might need this PR and do it your way.

Right, yes. So we will need this PR. Thank you.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd4687/28392/summary.html
COMMIT: d91612c
CMSSW: CMSSW_12_6_X_2022-10-19-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39789/28392/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 12 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3391158
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3391127
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 201 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1