-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12_5_X] [L1T] Backport of : Bug fix on L1TrackJetEmulator #39576
Conversation
backport of #39479 |
A new Pull Request was created by @cecilecaillol for CMSSW_12_5_X. It involves the following packages:
@rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test |
type bug-fix |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33846b/27927/summary.html Comparison SummarySummary:
|
+l1 |
+upgrade
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Bug fix on the L1 phase2 trackjet emulation.
Description of the problem: In cases were no tracks are found the code does not return empty containers. It returns nothing with result of failing in later steps or in offline analysis when we try to access them. This is important for samples with PU=0 were the possibility to have events w/o tracks is non-negligible.
Solution: Straightforward just added the empty containers. The change is transparent, just the minimum to prevent the crashes.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #39479
Backport needed for phase-2 L1 MC production