Bug fix on L1TrackJetEmulator #39479
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39479/32212
|
|
A new Pull Request was created by @gkaratha for master. It involves the following packages:
@rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f97616/27734/summary.html Comparison SummarySummary:
|
|
+l1 |
|
please test |
| @@ -243,6 +244,10 @@ void L1TrackJetEmulationProducer::produce(Event &iEvent, const EventSetup &iSetu | |||
| delete[] mzb.clusters; | |||
| } else if (L1TrkPtrs_.empty()) { | |||
There was a problem hiding this comment.
Is it not just else of this line,
if (!L1TrkPtrs_.empty()) ?
There was a problem hiding this comment.
Hello, yes it is just the else.
There was a problem hiding this comment.
Should we change to else then?
There was a problem hiding this comment.
If you think is necessary yes. I am re-writting the code anyway. In the new version I have this [*]. Instead of adding multiple brackets with else and if I only check if it is enmpty and if so return empty pointers.
if (L1TrkPtrs_.empty()){
if (displaced_)
iEvent.put(std::move(L1TrackJetContainer), "L1TrackJetsExtended");
else
iEvent.put(std::move(L1TrackJetContainer), "L1TrackJets");
return;
}
There was a problem hiding this comment.
Sorry, I confuse. Will you rewrite the follow up PR? Then I am ok.
There was a problem hiding this comment.
Hello,
I am re-writing the code altogether. I can make this change in this PR or I can leave it as is for now, and then when l1t offline gets merged it will change automatically. Sorry for the confusion.
Best,
george
There was a problem hiding this comment.
OK thanks. Then I think we can leave this for now, when PR test is done and success, we can sign.
|
Did the test get stuck? |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f97616/27936/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
|
+upgrade
|
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
ping bot |
PR description:
Bug fix on the L1 phase2 trackjet emulation.
Description of the problem: In cases were no tracks are found the code does not return empty containers. It returns nothing with result of failing in later steps or in offline analysis when we try to access them. This is important for samples with PU=0 were the possibility to have events w/o tracks is non-negligible.
Solution: Straightforward just added the empty containers. The change is transparent, just the minimum to prevent the crashes.