Require the AlpakaService to be enabled before running on a Device #39498

fwyzard · 2022-09-25T16:32:26Z

PR description:

Require the AlpakaService to be enabled before running on a Device.

Move the check that the corresponding AlpakaService is enabled from the beginStream() method of each EDProducer to the alpakatools::chooseDevice() central function.

This replicates the behaviour currently used by the CUDA "framework".

PR validation:

Unit tests pass.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 12.5.x.

cmsbuild · 2022-09-25T16:39:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39498/32249

This PR adds an extra 12KB to repository

cmsbuild · 2022-09-25T16:39:36Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

HeterogeneousCore/AlpakaCore (heterogeneous)
HeterogeneousCore/AlpakaTest (heterogeneous)

@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

fwyzard · 2022-09-25T16:52:08Z

please test

cmsbuild · 2022-09-26T00:07:36Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91987d/27763/summary.html
COMMIT: 8971c27
CMSSW: CMSSW_12_6_X_2022-09-25-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39498/27763/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91987d/27763/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91987d/27763/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3624368
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3624335
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

HeterogeneousCore/AlpakaCore/interface/chooseDevice.h

fwyzard · 2022-09-26T22:11:02Z

Good point, I'll give it some more thoughts.

fwyzard · 2022-10-03T16:39:55Z

enable gpu

fwyzard · 2022-10-03T16:40:01Z

please test

Move the check that the corresponding AlpakaService is enabled from the beginStream() method of each EDProducer to thealpakatools::chooseDevice() central function. This replicates the behaviour currently used by the CUDA "framework".

fwyzard · 2022-10-28T12:17:11Z

Rebased.

fwyzard · 2022-10-28T12:18:53Z

enable gpu

fwyzard · 2022-10-28T12:18:58Z

please test

fwyzard · 2022-10-28T12:19:04Z

+heterogeneous

cmsbuild · 2022-10-28T12:21:46Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39498/32818

This PR adds an extra 12KB to repository

cmsbuild · 2022-10-28T12:22:09Z

Pull request #39498 was updated. can you please check and sign again.

cmsbuild · 2022-10-28T18:52:39Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91987d/28603/summary.html
COMMIT: 1a3bb77
CMSSW: CMSSW_12_6_X_2022-10-28-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39498/28603/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3416356
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3416331
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 206 log files, 48 edm output root files, 48 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19876
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 19867
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: no differences found

rappoccio · 2022-10-28T19:08:01Z

+1

Relval input failures unrelated to this PR.

perrotta · 2022-10-28T19:38:19Z

merge
(in the status of "test-rejected" an explicit merge is needed)

cmsbuild added this to the CMSSW_12_6_X milestone Sep 25, 2022

cmsbuild added code-checks-pending heterogeneous-pending orp-pending pending-signatures tests-pending labels Sep 25, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 25, 2022

fwyzard mentioned this pull request Sep 25, 2022

Require the AlpakaService to be enabled before running on a Device [12.5.x] #39497

Merged

cmsbuild added tests-started and removed tests-pending labels Sep 25, 2022

cmsbuild added tests-rejected and removed tests-started labels Sep 26, 2022

makortel reviewed Sep 26, 2022

View reviewed changes

HeterogeneousCore/AlpakaCore/interface/chooseDevice.h Show resolved Hide resolved

This was referenced Sep 27, 2022

Tracker Traits and Enabling Phase2 for Inner Tracker Reconstruction on GPU #38761

Merged

Read SoA scalars and Eigen columns from a ROOT streamer #39532

Merged

Add helper functions for alpaka kernels #39546

Merged

HGCAL: Change ToA to local time #39447

Closed

fwyzard force-pushed the alpaka_framework_126x branch from 8971c27 to 5e92241 Compare October 3, 2022 16:36

cmsbuild added code-checks-pending tests-pending and removed tests-rejected code-checks-approved labels Oct 3, 2022

cmsbuild added the tests-approved label Oct 4, 2022

fwyzard force-pushed the alpaka_framework_126x branch from 5e92241 to 1a3bb77 Compare October 28, 2022 12:15

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels Oct 28, 2022

cmsbuild added fully-signed heterogeneous-approved tests-started and removed pending-signatures tests-pending heterogeneous-pending labels Oct 28, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 28, 2022

cmsbuild added tests-rejected and removed tests-started labels Oct 28, 2022

cmsbuild added orp-approved and removed orp-pending labels Oct 28, 2022

cmsbuild merged commit 11f1def into cms-sw:master Oct 28, 2022

fwyzard deleted the alpaka_framework_126x branch October 29, 2022 08:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Require the AlpakaService to be enabled before running on a Device #39498

Require the AlpakaService to be enabled before running on a Device #39498

fwyzard commented Sep 25, 2022

cmsbuild commented Sep 25, 2022

cmsbuild commented Sep 25, 2022

fwyzard commented Sep 25, 2022

cmsbuild commented Sep 26, 2022

fwyzard commented Sep 26, 2022

fwyzard commented Oct 3, 2022

fwyzard commented Oct 3, 2022

fwyzard commented Oct 28, 2022

fwyzard commented Oct 28, 2022

fwyzard commented Oct 28, 2022

fwyzard commented Oct 28, 2022

cmsbuild commented Oct 28, 2022

cmsbuild commented Oct 28, 2022

cmsbuild commented Oct 28, 2022

rappoccio commented Oct 28, 2022

perrotta commented Oct 28, 2022

Require the AlpakaService to be enabled before running on a Device #39498

Require the AlpakaService to be enabled before running on a Device #39498

Conversation

fwyzard commented Sep 25, 2022

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Sep 25, 2022

cmsbuild commented Sep 25, 2022

fwyzard commented Sep 25, 2022

cmsbuild commented Sep 26, 2022

Unit Tests

Comparison Summary

fwyzard commented Sep 26, 2022

fwyzard commented Oct 3, 2022

fwyzard commented Oct 3, 2022

fwyzard commented Oct 28, 2022

fwyzard commented Oct 28, 2022

fwyzard commented Oct 28, 2022

fwyzard commented Oct 28, 2022

cmsbuild commented Oct 28, 2022

cmsbuild commented Oct 28, 2022

cmsbuild commented Oct 28, 2022

RelVals-INPUT

Comparison Summary

GPU Comparison Summary

rappoccio commented Oct 28, 2022

perrotta commented Oct 28, 2022