Require the AlpakaService to be enabled before running on a Device [12.5.x] #39497

fwyzard · 2022-09-25T16:30:23Z

PR description:

Require the AlpakaService to be enabled before running on a Device.

Move the check that the corresponding AlpakaService is enabled from the beginStream() method of each EDProducer to the alpakatools::chooseDevice() central function.

This replicates the behaviour currently used by the CUDA "framework".

PR validation:

Unit tests pass.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #39498 to 12.5.x.

cmsbuild · 2022-09-25T16:30:41Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_5_X.

It involves the following packages:

HeterogeneousCore/AlpakaCore (heterogeneous)
HeterogeneousCore/AlpakaTest (heterogeneous)

@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

Backported from Require the AlpakaService to be enabled before running on a Device #39498

fwyzard · 2022-09-25T16:51:56Z

backport #39498

fwyzard · 2022-09-25T16:52:13Z

please test

cmsbuild · 2022-09-25T20:51:21Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a4aa4/27762/summary.html
COMMIT: 3b56704
CMSSW: CMSSW_12_5_X_2022-09-25-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39497/27762/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3699454
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3699418
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

cmsbuild · 2022-10-03T16:37:26Z

Pull request #39497 was updated. @cmsbuild, @makortel, @fwyzard can you please check and sign again.

fwyzard · 2022-10-03T16:39:33Z

enable gpu

fwyzard · 2022-10-03T16:39:35Z

please test

cmsbuild · 2022-10-03T22:17:44Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a4aa4/27946/summary.html
COMMIT: 5e92241
CMSSW: CMSSW_12_5_X_2022-10-03-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39497/27946/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

50204.050204.0_QQH1352T_13+QQH1352T_13INPUT+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_QQH1352T_13+QQH1352T_13INPUT+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
50205.0DAS Error
50206.0DAS Error

Expand to see more relval errors ...

50207.0
50208.0
1003.0
1010.0
1020.0
1102.0
4000.0
4001.0
4002.0
4003.0
10004.0
10008.0
10023.0
10024.1
10024.2
10024.4
10025.0
10071.0
10224.0
10801.0
10804.0
10805.31
10806.0
10823.0
10824.5
10824.501
10824.6
10824.8
10842.0
10842.505
11024.0
11024.15
11025.0
11224.6

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3699454
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3699424
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
Reco comparison had 3 failed jobs
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19876
DQMHistoTests: Total failures: 10
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 19866
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: no differences found

fwyzard · 2022-10-03T22:18:30Z

please test

cmsbuild · 2022-10-04T03:15:51Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a4aa4/27958/summary.html
COMMIT: 5e92241
CMSSW: CMSSW_12_5_X_2022-10-03-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39497/27958/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3699454
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3699418
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19876
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 19868
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: no differences found

Move the check that the corresponding AlpakaService is enabled from the beginStream() method of each EDProducer to thealpakatools::chooseDevice() central function. This replicates the behaviour currently used by the CUDA "framework".

cmsbuild · 2022-10-28T12:15:47Z

Pull request #39497 was updated. @cmsbuild, @makortel, @fwyzard can you please check and sign again.

fwyzard · 2022-10-28T12:17:03Z

Rebased.

fwyzard · 2022-10-28T12:19:13Z

enable gpu

fwyzard · 2022-10-28T12:19:17Z

please test

fwyzard · 2022-10-28T12:19:19Z

+heterogeneous

cmsbuild · 2022-10-28T12:19:36Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2022-10-28T19:01:13Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a4aa4/28602/summary.html
COMMIT: 1a3bb77
CMSSW: CMSSW_12_5_X_2022-10-28-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39497/28602/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3702776
DQMHistoTests: Total failures: 148
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3702606
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19876
DQMHistoTests: Total failures: 16
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 19860
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: no differences found

perrotta · 2022-10-29T06:50:56Z

+1

cmsbuild added this to the CMSSW_12_5_X milestone Sep 25, 2022

cmsbuild added heterogeneous-pending orp-pending pending-signatures tests-pending labels Sep 25, 2022

cmsbuild added the backport label Sep 25, 2022

cmsbuild added tests-started and removed tests-pending labels Sep 25, 2022

cmsbuild added tests-approved and removed tests-started labels Sep 25, 2022

fwyzard force-pushed the alpaka_framework_125x branch from 3b56704 to 5e92241 Compare October 3, 2022 16:37

cmsbuild added tests-pending and removed tests-approved labels Oct 3, 2022

cmsbuild added tests-started and removed tests-pending labels Oct 3, 2022

cmsbuild added tests-rejected and removed tests-started labels Oct 3, 2022

cmsbuild added tests-started and removed tests-rejected labels Oct 3, 2022

cmsbuild removed the tests-started label Oct 4, 2022

cmsbuild added the tests-approved label Oct 4, 2022

fwyzard force-pushed the alpaka_framework_125x branch from 5e92241 to 1a3bb77 Compare October 28, 2022 12:15

cmsbuild added tests-pending and removed tests-approved labels Oct 28, 2022

cmsbuild added fully-signed heterogeneous-approved tests-started and removed pending-signatures tests-pending heterogeneous-pending labels Oct 28, 2022

cmsbuild added tests-approved backport-ok and removed tests-started backport labels Oct 28, 2022

cmsbuild added orp-approved and removed orp-pending labels Oct 29, 2022

cmsbuild merged commit 74eecb0 into cms-sw:CMSSW_12_5_X Oct 29, 2022

fwyzard deleted the alpaka_framework_125x branch October 29, 2022 08:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Require the AlpakaService to be enabled before running on a Device [12.5.x] #39497

Require the AlpakaService to be enabled before running on a Device [12.5.x] #39497

fwyzard commented Sep 25, 2022 •

edited

Loading

cmsbuild commented Sep 25, 2022 •

edited

Loading

fwyzard commented Sep 25, 2022

fwyzard commented Sep 25, 2022

cmsbuild commented Sep 25, 2022

cmsbuild commented Oct 3, 2022

fwyzard commented Oct 3, 2022

fwyzard commented Oct 3, 2022

cmsbuild commented Oct 3, 2022

fwyzard commented Oct 3, 2022

cmsbuild commented Oct 4, 2022

cmsbuild commented Oct 28, 2022

fwyzard commented Oct 28, 2022

fwyzard commented Oct 28, 2022

fwyzard commented Oct 28, 2022

fwyzard commented Oct 28, 2022

cmsbuild commented Oct 28, 2022

cmsbuild commented Oct 28, 2022

perrotta commented Oct 29, 2022

Require the AlpakaService to be enabled before running on a Device [12.5.x] #39497

Require the AlpakaService to be enabled before running on a Device [12.5.x] #39497

Conversation

fwyzard commented Sep 25, 2022 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Sep 25, 2022 • edited Loading

fwyzard commented Sep 25, 2022

fwyzard commented Sep 25, 2022

cmsbuild commented Sep 25, 2022

Comparison Summary

cmsbuild commented Oct 3, 2022

fwyzard commented Oct 3, 2022

fwyzard commented Oct 3, 2022

cmsbuild commented Oct 3, 2022

RelVals-INPUT

Comparison Summary

GPU Comparison Summary

fwyzard commented Oct 3, 2022

cmsbuild commented Oct 4, 2022

Comparison Summary

GPU Comparison Summary

cmsbuild commented Oct 28, 2022

fwyzard commented Oct 28, 2022

fwyzard commented Oct 28, 2022

fwyzard commented Oct 28, 2022

fwyzard commented Oct 28, 2022

cmsbuild commented Oct 28, 2022

cmsbuild commented Oct 28, 2022

Comparison Summary

GPU Comparison Summary

perrotta commented Oct 29, 2022

fwyzard commented Sep 25, 2022 •

edited

Loading

cmsbuild commented Sep 25, 2022 •

edited

Loading