-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.5.X] Fix testNoParentDictionary to properly copy the package from release area #39492
Conversation
please test |
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_12_5_X. It involves the following packages:
@makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21c1d2/27757/summary.html Comparison SummarySummary:
|
+1 |
Thanks! |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #39367
In patch release we could have symlinks src/SubSystem/Package pointing to FULL_RELEASE/src/SubSystem/Package . This can cause the unit test testNoParentDictionary.sh to fail. This change now properly copies the package DataFormats/TestObjects from patch release by dereferencing the symlink