fix testNoParentDictionary to properly copy the contents of DataFormats/TestObjects

[smuzaffar]

In patch release we could have symlinks src/SubSystem/Package pointing to FULL_RELEASE/src/SubSystem/Package . This can cause the unit test testNoParentDictionary.sh to fail. This change now properly copies the package DataFormats/TestObjects from patch release by dereferencing the symlink

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39367/32066

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• IOPool/Input (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

Thanks @smuzaffar!

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcc2d9/27467/summary.html
COMMIT: c4ff456
CMSSW: CMSSW_12_6_X_2022-09-11-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39367/27467/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3618326
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3618296
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[makortel]

@smuzaffar Was this test enough to convince ourselves that the TestIOPoolInputNoParentDictionary is now more robust? (CMSSW_12_6_X_2022-09-11-2300/el8_amd64_gcc10 was a patch release, for what's it worth)

[smuzaffar]

@makortel , in order to test it properly we need a cmssw patch IB where DataFormats/TestObjects is symlink and currently there is no such IB for this week. Anyway, I have tested it against last week's CMSSW_12_6_X_2022-09-10-1100 IB and it works.

[makortel]

+1

Thanks. Ok, so the scenario leading to the test failure was even more convoluted than I thought.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1