Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLT menu development for 12_4_X (8/N): HLT V1.4 of 2022 [12_6_X] #39419

Merged
merged 2 commits into from
Sep 17, 2022
Merged

HLT menu development for 12_4_X (8/N): HLT V1.4 of 2022 [12_6_X] #39419

merged 2 commits into from
Sep 17, 2022

Conversation

missirol
Copy link
Contributor

PR description:

Development of HLT menus for CMSSW_12_4_X.

This version of the GRun HLT menu corresponds to "HLT V1.4" for 2022 pp data-taking.

This is the PR for the master branch, which will then be backported to 12_5_X and 12_4_X (the latter is the release cycle currently used for HLT-menu development for Run 3).

Includes the integration of the following JIRA tickets.

  • CMSHLT-2461: [TSG] trigger for GPU-vs-CPU differences in AlCa_PFJet40
  • CMSHLT-2352: [EXO] update of signal and control triggers for delayed-jet searches
  • CMSHLT-2448: [TAU] tighten DeepTau wp for ditau triggers
  • CMSHLT-2472: [TAU] re-add TAU backup triggers to GRun with PS=0
  • CMSHLT-2468: [TSG] add OnlyMuons PS column
  • CMSHLT-2467: [BPH] new lumi-based PS columns for BPH Parking
  • CMSHLT-2454: [ECAL] run CPU ECAL unpacker on GPU to provide auxiliary collections
  • CMSHLT-2445: [EXO] disable HLT_HT430_DisplacedDijet30_Inclusive1PtrkShortSig5
  • CMSHLT-2469: [EXO] fix to inclusive delayed-jet triggers
  • CMSHLT-2465: [MUO-DPGs] increase rate of muon triggers in Express PD
  • CMSHLT-2466: [TAU] add L1_DoubleIsoTau35er2p1 to relevant L1T seeds
  • CMSHLT-2455: [PFlow] set maxIterations=5 in HBHE-PFClustering
  • CMSHLT-2453: [EXO] fix to thresholds of DTCluster-based triggers
  • CMSHLT-2463: [MUO] set PS=2 for HLT_Mu15
  • CMSHLT-2464: [TRK] added RAW of OnlineMetaData to EventContent of DQMOnlineBeamSpot
  • CMSHLT-2456: [TSG] remove unnecessary process-names in InputTags
  • CMSHLT-2410: [EXO] enable DiPhoton10Time1p2ns trigger
  • CMSHLT-2457: [B2G] remove BoostedDoubleB triggers from GRun
  • CMSHLT-2447: [JME] Add DiPFJetAve260_HFJEC trigger
  • CMSHLT-2450: [JME] Add uncorrected version of jets to the EventContent of the ALCALowPtJet stream
  • CMSHLT-2449: [DAQ,MUO] update of MessageLogger module to suppress known MUO-related warnings

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_12_4_X
CMSSW_12_5_X

@cmsbuild cmsbuild added this to the CMSSW_12_6_X milestone Sep 16, 2022
This was referenced Sep 16, 2022
Merged
Merged
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39419/32127

  • This PR adds an extra 1432KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

missirol
missirol commented Sep 16, 2022
View reviewed changes
HLTrigger/Configuration/scripts/hltIntegrationTests
@@ -241,7 +241,7 @@ mkdir "$WORKDIR"
cd "$WORKDIR"

# find the list of all trigger paths
TRIGGERS=$(hltListPaths "$MENU" $HLTLISTPATHPROXY -p --no-dep --exclude "^HLTriggerFinalPath$" "^Dataset_.+" "^DST_HLTMuon_Run3_PFScoutingPixelTracking_v[0-9]+$")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realised that these hard-coded names can be removed here; specifying --no-dep is sufficient to omit Paths that depend on other Paths.

@missirol
Copy link
Contributor Author

enable gpu

@missirol
Copy link
Contributor Author

please test

@missirol
Copy link
Contributor Author

The relvals/gpu test seems to be stuck. Hopefully, it's not the same issue as in #39113 (comment).

I guess I might have to reboot the tests, if things don't change.

@missirol
Copy link
Contributor Author

please abort

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7ffed/27617/summary.html
COMMIT: 2282979
CMSSW: CMSSW_12_6_X_2022-09-16-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39419/27617/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19876
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19868
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: no differences found

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3610896
  • DQMHistoTests: Total failures: 229
  • DQMHistoTests: Total nulls: 77
  • DQMHistoTests: Total successes: 3610568
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -586.548 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -290.974 KiB HLT/JME
  • DQMHistoSizes: changed ( 11634.0,... ): 144.307 KiB HLT/TAU
  • DQMHistoSizes: changed ( 11634.0,... ): 24.115 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 11634.0,... ): 21.999 KiB HLT/Muon
  • DQMHistoSizes: changed ( 11634.0,... ): 2.795 KiB HLT/Filters
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

  • differences in outputs of PR tests are in line with changes to the HLT menus

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit de3a0fb into cms-sw:master Sep 17, 2022
@missirol missirol deleted the HLTdevelopment124X_for126X branch September 17, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved fully-signed hlt-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_12_6_X
Development

Successfully merging this pull request may close these issues.
3 participants
@missirol @cmsbuild @perrotta