Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 12_4_X (7/N) [12_5_X] #39113

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

missirol
Copy link
Contributor

PR description:

Development of HLT menus for CMSSW_12_4_X.

This is the PR for the master branch, which will then be backported to 12_4_X (the latter is the release cycle currently used for HLT-menu development for Run 3).

Includes the integration of the following JIRA tickets.

  • CMSHLT-2312 (part 2): [MUO] renaming of muon-isolation modules
  • CMSHLT-2418 (part 2): [EXO] added backup seeds to L1T-MET-seeds module
  • CMSHLT-2420: [EXO] set PS=100 for two HLT_DiPhoton10sminlt triggers
  • CMSHLT-2426: [TSG] updated list of backup L1T-MET seeds (e.g. L1_ETMHF{130,140})
  • CMSHLT-2427: [HIG] fix for PNET-AK8 outputs in EventContent of HLTMonitor stream
  • CMSHLT-2408: [BTV] removal of disabled DeepJet triggers from HLTMonitor PD
  • CMSHLT-2428: [TSG] addition of Scouting Path seeded by Muon PD
  • CMSHLT-2431: [TSG] reorganisation of Streams for Muon, JetMET and ReservedDoubleMuonLowMass PDs
  • CMSHLT-2434: [TSG] updated settings of FedRawDataInputSource
  • CMSHLT-2435: [TSG] removal of the "1.7 to 0.6e34 No Parking" PS column
  • CMSHLT-2373: [MUO] added new Mu50_L1SingleMuShower trigger with PS=0
  • CMSHLT-2440: [TSG] halved HLT PS of 4 HLT_Mu control triggers
  • CMSHLT-2442: [TSG] set PS=0 for HLT_Ele28_WPTight_Gsf

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_12_4_X

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39113/31651

  • This PR adds an extra 888KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

enable gpu

@missirol
Copy link
Contributor Author

please test

@missirol
Copy link
Contributor Author

The GPU tests weren't able to start in the last 2 days.

@smuzaffar , could you please check if this is expected, or if something is stuck?

@smuzaffar
Copy link
Contributor

@missirol , no idea what had happened to previous gpu relval job. I have restarted the gpu tests now

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf36fa/26930/summary.html
COMMIT: f1947bc
CMSSW: CMSSW_12_5_X_2022-08-18-2300/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39113/26930/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • Reco comparison had 3 failed jobs
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19876
  • DQMHistoTests: Total failures: 36
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19840
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: found differences in 3 / 3 workflows

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3692530
  • DQMHistoTests: Total failures: 87
  • DQMHistoTests: Total nulls: 13
  • DQMHistoTests: Total successes: 3692408
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -4.078 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -0.844 KiB HLT/Muon
  • DQMHistoSizes: changed ( 11634.0,... ): 0.165 KiB HLT/Filters
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 6 / 50 workflows

@missirol
Copy link
Contributor Author

I have restarted the gpu tests now

thanks, @smuzaffar !

@missirol
Copy link
Contributor Author

+hlt

  • differences in outputs of PR tests are in line with updates to the HLT GRun menu

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants