-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECAL - Switch off online ECAL RecHit GPU vs. CPU monitoring - 12_5_X #39394
ECAL - Switch off online ECAL RecHit GPU vs. CPU monitoring - 12_5_X #39394
Conversation
A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_12_5_X. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Backport of #39393 |
enable gpu |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d3105/27548/summary.html GPU Comparison SummarySummary:
Comparison SummarySummary:
|
…ng is switched off.
Pull request #39394 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again. |
please test with #39372 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d3105/27592/summary.html GPU Comparison SummarySummary:
Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Switches off the online ECAL RecHit GPU vs. CPU comparisons since the RecHit module is identical in both options.
Until PR #39372 is merged the collections are still consumed so the same existing RecHit collection is used for CPU and GPU inputs.Requires PR #39372 to be merged since the RecHit collection tags have been removed from the configuration.
PR validation:
Configured and ran cmsRun with the configuration but no events were processed since the source is a stream that was not available. Should be tested on the playback system as well.
Backport of #39393