[12_5_X] ECAL DQM GpuTask move enable flag checks to avoid unused collections from being consumed

[alejands]

PR description:

The GpuTask switches for toggling individual collections were not being checked before the collection tags were consumed. The initial check is done here:

cmssw/DQM/EcalMonitorTasks/plugins/EcalDQMonitorTask.cc

Lines 46 to 48 in e5ac8e9

	for (unsigned iCol(0); iCol < ecaldqm::nCollections; ++iCol) {
	if (task->analyze(nullptr, ecaldqm::Collections(iCol))) // "dry run" mode
	hasTaskToRun.set(iCol);

task->analyze() here needs to return false so the collections aren't consumed.

The consumes functions are then called inside this function:

cmssw/DQM/EcalMonitorTasks/plugins/EcalDQMonitorTask.cc

Line 64 in e5ac8e9

formSchedule(dependencies.formSequence(), collectionTags);

The switches are moved to make sure that unused collections are not consumed if they are individually toggled.

PR validation:

Code compiles. The switches are now in the same spot as the "master" switch runGpuTask which we already know functions as expected.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport to use the fix in production. The PR to master is here:

• ECAL DQM GpuTask move enable flag checks to avoid unused collections from being consumed #39371

The other backport is here:

• [12_4_X] ECAL DQM GpuTask move enable flag checks to avoid unused collections from being consumed #39373

[cmsbuild]

A new Pull Request was created by @alejands (Alejandro Sanchez) for CMSSW_12_5_X.

It involves the following packages:

• DQM/EcalMonitorTasks (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from ECAL DQM GpuTask move enable flag checks to avoid unused collections from being consumed #39371

[emanueleusai]

please test

[emanueleusai]

type ecal

[emanueleusai]

type bug

[emanueleusai]

backport of #39371

[thomreis]

enable gpu

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59809b/27490/summary.html
COMMIT: ffdb7a8
CMSSW: CMSSW_12_5_X_2022-09-12-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39372/27490/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3695824
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3695794
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59809b/27512/summary.html
COMMIT: ffdb7a8
CMSSW: CMSSW_12_5_X_2022-09-13-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39372/27512/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• Reco comparison had 3 failed jobs
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19876
• DQMHistoTests: Total failures: 10
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19866
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3695824
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3695788
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

• test at P5 of 12_4 backport completed successfully
• differences in DQM plots in GPU comparison due to random seed understood

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1