Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Add check of Tracker HV in BeamSpot DQM clients #39353

Merged

Conversation

francescobrivio
Copy link
Contributor

PR description:

Backport of #39347
This also includes the backport of #38925 (update the unitTest input file) which is a 1 commit PR that was never backport to 12_4_X.

A check on the Tracker HV (both pixels and strips) is added in order not to run on events which are by construction not useful for the BeamSpot determination.
Plus some minor improvements to the DQM BeamSpot clients.

PR validation:

See master PR

Backport:

Backport of #39347

@francescobrivio
Copy link
Contributor Author

backport of #39347

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2022

A new Pull Request was created by @francescobrivio for CMSSW_12_4_X.

It involves the following packages:

  • DQM/Integration (dqm)
  • RecoVertex/BeamSpotProducer (reconstruction, alca)

@malbouis, @yuanchao, @pmandrik, @micsucmed, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @ChrisMisan, @jfernan2, @clacaputo, @syuvivida, @saumyaphor4252, @francescobrivio, @mandrenguyen, @rvenditti can you please review it and eventually sign? Thanks.
@VourMa, @battibass, @mtosi, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @rovere, @mmusich, @threus, @dgulhan, @batinkov this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

type performance-improvement

@francescobrivio
Copy link
Contributor Author

urgent

  • meant for the new 12_4_X release for data-taking

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@mandrenguyen
Copy link
Contributor

+1

@syuvivida
Copy link
Contributor

syuvivida commented Sep 9, 2022

+1
This PR passed the test at playback.

@saumyaphor4252
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eea644/27440/summary.html
COMMIT: 777967c
CMSSW: CMSSW_12_4_X_2022-09-08-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39353/27440/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3677396
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3677360
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@rappoccio
Copy link
Contributor

+1

@rappoccio rappoccio merged commit 713a0ca into cms-sw:CMSSW_12_4_X Sep 9, 2022
@francescobrivio francescobrivio deleted the alca-add_HV_check_12_4_X branch September 14, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants