-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check of Tracker HV in BeamSpot DQM clients #39347
Conversation
type performance-improvement |
@cms-sw/dqm-l2 please advise if you agree with the I'll wait for your feedback on these two points before opening the backports, but keep in mind it would be nice to have this merged and backported in the new 12_4_X for when the collision data-taking restarts. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39347/32049
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages:
@malbouis, @yuanchao, @micsucmed, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @ChrisMisan, @jfernan2, @clacaputo, @pmandrik, @saumyaphor4252, @francescobrivio, @mandrenguyen, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
@cms-sw/reconstruction-l2 just FYI the |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-66b1df/27427/summary.html Comparison SummarySummary:
|
+1 |
+reconstruction |
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
+1 |
PR description:
In this PR a few improvements to the BeamSpot DQM clients are made:
beamhlt
client requires a change in the event content of thestreamDQMOnlineBeamspot
to include the raw data from FED 1022 via a newhltFEDSelectorOnlineMetaData
This is being implemented by @missirol as described in JIRA-CMSHLT-2464
beam
client as the full raw data information is already available in the standardstreamDQM
event contentunitteststreamerinputsource_cfi.py
config file has been added for the specific cases where the unitTests are running on streamer filesbeamhlt
DQM client is using this feature, but more clients could be adapted in the futureLogInfo
printout ofRecoVertex/BeamSpotProducer/plugins/OnlineBeamSpotESProducer.cc
has been fixedPR validation:
Code compiles plus successfully run:
Backport:
Not a backport but 12_5_X and 12_4_X backports will be opened soon.
FYI @gennai @dzuolo @mmusich @ggovi