Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check of Tracker HV in BeamSpot DQM clients #39347

Merged
merged 3 commits into from
Sep 9, 2022

Conversation

francescobrivio
Copy link
Contributor

PR description:

In this PR a few improvements to the BeamSpot DQM clients are made:

  • A check on the Tracker HV (both pixels and strips) is added in order not to run on events which are by construction not useful for the BeamSpot determination
    • This will alleviate the stress on the CondDB unfrastructure by reducing the number of "fake-failing" BeamSpot logs that are uploaded to the DB and that are monitored by the DB Experts on call (FYI @cms-sw/db-l2)
    • The HV check in the beamhlt client requires a change in the event content of the streamDQMOnlineBeamspot to include the raw data from FED 1022 via a new hltFEDSelectorOnlineMetaData
      This is being implemented by @missirol as described in JIRA-CMSHLT-2464
    • No additional changes are needed for the HV check in the beam client as the full raw data information is already available in the standard streamDQM event content
  • An explicit printout of the Global Tag used by the client is added to the client logs
  • A new unitteststreamerinputsource_cfi.py config file has been added for the specific cases where the unitTests are running on streamer files
    • Currently only the beamhlt DQM client is using this feature, but more clients could be adapted in the future
    • The new config allows to avoid querying DAS uselessly since the input streamer files are read from cms-data/DQM-Integration
  • A typo in the LogInfo printout of RecoVertex/BeamSpotProducer/plugins/OnlineBeamSpotESProducer.cc has been fixed

PR validation:

Code compiles plus successfully run:

scram b runtests_TestDQMOnlineClient-beam_dqm_sourceclient 
scram b runtests_TestDQMOnlineClient-beamhlt_dqm_sourceclient

Backport:

Not a backport but 12_5_X and 12_4_X backports will be opened soon.

FYI @gennai @dzuolo @mmusich @ggovi

@francescobrivio
Copy link
Contributor Author

type performance-improvement

@francescobrivio
Copy link
Contributor Author

francescobrivio commented Sep 8, 2022

@cms-sw/dqm-l2 please advise if you agree with the unitteststreamerinputsource_cfi.py name or if you prefer a different nomenclature.
Also, please let me know if you agree with the default options that are registered in this new config file.

I'll wait for your feedback on these two points before opening the backports, but keep in mind it would be nice to have this merged and backported in the new 12_4_X for when the collision data-taking restarts.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39347/32049

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2022

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • DQM/Integration (dqm)
  • RecoVertex/BeamSpotProducer (reconstruction, alca)

@malbouis, @yuanchao, @micsucmed, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @ChrisMisan, @jfernan2, @clacaputo, @pmandrik, @saumyaphor4252, @francescobrivio, @mandrenguyen, @rvenditti can you please review it and eventually sign? Thanks.
@VourMa, @battibass, @mtosi, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @rovere, @mmusich, @threus, @dgulhan, @batinkov this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@francescobrivio
Copy link
Contributor Author

@cms-sw/reconstruction-l2 just FYI the reco change here is only a typo in a LogInfo printout :D

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-66b1df/27427/summary.html
COMMIT: 55dd8ee
CMSSW: CMSSW_12_6_X_2022-09-07-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39347/27427/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3618326
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3618299
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@mandrenguyen
Copy link
Contributor

+reconstruction
reco only triggered b/c a typo was fixed in a LogInfo

@tvami
Copy link
Contributor

tvami commented Sep 8, 2022

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Sep 9, 2022

+1

@cmsbuild cmsbuild merged commit 55e19a3 into cms-sw:master Sep 9, 2022
@syuvivida
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants