-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Pixel Clusters for Phase2 HLT Menu #39323
Fix Pixel Clusters for Phase2 HLT Menu #39323
Conversation
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39323/32022
|
A new Pull Request was created by @AdrianoDee for master. It involves the following packages:
@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a41fd/27381/summary.html Comparison SummarySummary:
|
type bugfix Fix to the HLT Phase-2 menu. |
This fix reminds that there is no DQM in wf I understood from #37162 (comment) that this was being worked on. @trtomei, can you remind me what is the plan for that? |
+hlt |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Q: would this PR need to be backported to 12_4 and 12_5 for studies? |
@AdrianoDee |
@trtomei , do you know if anybody is working on adding DQM to the wf testing the HLT Phase-2 menu? |
Is there an issue for that or shall we open it? |
I don't think there is; it's probably good to open one. |
PR description:
This PR realigns the
siPixelClusters
module used in Phase2 HLT menu to the one up to date in the release. Without this fix the pixel clustering parameters used in the menu are obsolete and this causes a huge drop in tracking efficiency.PR validation:
Running the menu the general tracks efficiency is recovered. Tested with
39434.75
wf.