Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pixel Clusters for Phase2 HLT Menu #39323

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

AdrianoDee
Copy link
Contributor

@AdrianoDee AdrianoDee commented Sep 6, 2022

PR description:

This PR realigns the siPixelClusters module used in Phase2 HLT menu to the one up to date in the release. Without this fix the pixel clustering parameters used in the menu are obsolete and this causes a huge drop in tracking efficiency.

PR validation:

Running the menu the general tracks efficiency is recovered. Tested with 39434.75 wf.

image

@cmsbuild cmsbuild added this to the CMSSW_12_6_X milestone Sep 6, 2022
@AdrianoDee AdrianoDee changed the title Fix pixel clusters for Phase2 HLT menu Fix Pixel Clusters for Phase2 HLT Menu Sep 6, 2022
@AdrianoDee
Copy link
Contributor Author

test parameters:

  • workflows = 39434.75
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39323/32022

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2022

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a41fd/27381/summary.html
COMMIT: 5dffef3
CMSSW: CMSSW_12_6_X_2022-09-06-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39323/27381/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3618210
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3618186
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 1 / 50 workflows

@missirol
Copy link
Contributor

missirol commented Sep 7, 2022

type bugfix

Fix to the HLT Phase-2 menu.

@missirol
Copy link
Contributor

missirol commented Sep 7, 2022

This fix reminds that there is no DQM in wf 39434.75 for the HLT Phase-2 menu.

I understood from #37162 (comment) that this was being worked on. @trtomei, can you remind me what is the plan for that?

@missirol
Copy link
Contributor

missirol commented Sep 7, 2022

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Sep 7, 2022

+1

@cmsbuild cmsbuild merged commit 1f86143 into cms-sw:master Sep 7, 2022
@Martin-Grunewald
Copy link
Contributor

Q: would this PR need to be backported to 12_4 and 12_5 for studies?

@Martin-Grunewald
Copy link
Contributor

@AdrianoDee
Please provide backport PRs for 12_4 and 12_5.
Thank you!

@missirol
Copy link
Contributor

missirol commented Sep 8, 2022

This fix reminds that there is no DQM in wf 39434.75 for the HLT Phase-2 menu.

I understood from #37162 (comment) that this was being worked on. @trtomei, can you remind me what is the plan for that?

@trtomei , do you know if anybody is working on adding DQM to the wf testing the HLT Phase-2 menu?

@AdrianoDee
Copy link
Contributor Author

This fix reminds that there is no DQM in wf 39434.75 for the HLT Phase-2 menu.

I understood from #37162 (comment) that this was being worked on. @trtomei, can you remind me what is the plan for that?

@trtomei , do you know if anybody is working on adding DQM to the wf testing the HLT Phase-2 menu?

Is there an issue for that or shall we open it?

@missirol
Copy link
Contributor

I don't think there is; it's probably good to open one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants