-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement the PortableCollection and related tests in CUDA #39319
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39319/32015
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages:
The following packages do not have a category, yet: CUDADataFormats/PortableTestObjects @cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
30a5539
to
c1f6600
Compare
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39319/32016
|
c1f6600
to
e84b4e3
Compare
c9a50cb
to
d2e962a
Compare
please test |
+heterogeneous I think this addresses all the comments. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39319/32046
|
Pull request #39319 was updated. can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58fd38/27419/summary.html GPU Comparison SummarySummary:
Comparison SummarySummary:
|
Going to hold off on this until Monday/Tuesday, the IBs have settled down but I think it's wise to only merge simple things for a few days. |
Sorry, that doesn't work for me.
Can you merge this in time for the Sunday night IB ?
|
+1 |
Thanks 👍🏼 |
PR description:
To ease the migration from CUDA to Alpaka, reimplement in CUDA the
PortableHostCollection
andPortableDeviceCollection
originally developed for the Alpaka data formats, along with thePortableTestObjects
tests.The CUDA version is in the
cms::cuda
namespace.The data format functionality requires extending the
cms::cuda::host::make_unique<T>
to support pageable (i.e. non-pinned) host memory.PR validation:
The new unit tests run successfully, both with and without GPUs:
Regarding the changes to the
cms::cuda::host::unique_ptr<T>
, they were tested also in CMSSW 12.4.8 on a GPU-enabled HLT workflow, to make sure they do not have any negative impact on the performance.Vanilla CMSSW_12_4_8
With the equivalent changes as in this PR:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
To be backported to CMSSW 12.5.x for the Alpaka migration.