-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SoA macros to CUDADataFormats/Common. #35951
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35951/26358
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35951/26359
|
A new Pull Request was created by @ericcano (Eric Cano) for master. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Thanks @ericcano. Given the dependence on Eigen, even a new package could be the justified. I presume the intention would be to use the SoA's also in pure host code (without any dependence on CUDA), the best placement would likely still be under @cms-sw/heterogeneous-l2 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35951/26390
|
Pull request #35951 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again. |
@ericcano Would you be able to present this model of building SoAs in the core software meeting on next Tuesday (Nov 9) or on the following week (Nov 16)? |
@makortel Yes, next Tuesday is fine. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35951/26446
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35951/29179
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35951/29185
|
Yes |
PR description:
The SoA macros generate classes that subdivide externally allocated buffer in
columns with alignement adequate for GPUs (by default).
An test validates the SoA and provides usage example.
PR validation:
This PR provide new tools and does not interfere yet with current production code. The tools itself is validated with a test program.