Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update muon shower (HMT) emulator [12_5_X] #39228

Merged
merged 13 commits into from
Sep 9, 2022
Merged

Update muon shower (HMT) emulator [12_5_X] #39228

merged 13 commits into from
Sep 9, 2022

Conversation

kakwok
Copy link
Contributor

@kakwok kakwok commented Aug 29, 2022

PR description:

Backport of #38941

Including emulator update in 12_5_X will help DQM comparison between data/emulator in P5 for HMT trigger.

DQM plots have already been enabled in: #38639

tahuang1991 and others added 10 commits July 28, 2022 13:37
@tahuang1991
Rebase step 2
a5a6c3b
code format
af71bd7
@tahuang1991
Merged HMT_emulation_12_5_X from repository kakwok with cms-merge-topic
f9ab48d
@tahuang1991
1.update CSCShowerDigi constructor and the codes that used the constr…
e6bd40e 
…uctor

2.Add two more shower types: EMTFShower and GMTShower
3.removed comment-out lines in CSCAnodeLCTProcessor.cc
@kakwok
Merge pull request #1 from tahuang1991/HMT_emulation_12_5_X
6d7b6e2 
Update the CSCDigi shower constructor and also where the constructor is called
@tahuang1991
fixed the code-format in CSCRawToDigi from scram build code-format
0c85cf6
@tahuang1991
Merge pull request #2 from tahuang1991/HMT_emulation_12_5_X
b6a117e 
fixed the code-format in CSCRawToDigi from scram build code-format
change class version to 12
35ff4e1
remove commented lines
5eb6603
move minbx_readout, maxbx_readout to header, assert minbx_readout>0
712e670
@cmsbuild cmsbuild added this to the CMSSW_12_5_X milestone Aug 29, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 29, 2022 •
edited
Loading

A new Pull Request was created by @kakwok for CMSSW_12_5_X.

It involves the following packages:

  • DataFormats/CSCDigi (simulation)
  • EventFilter/CSCRawToDigi (reconstruction)
  • EventFilter/L1TRawToDigi (l1)
  • L1Trigger/CSCTriggerPrimitives (l1)

@civanch, @epalencia, @clacaputo, @cmsbuild, @rekovic, @mdhildreth, @jpata, @mandrenguyen, @cecilecaillol can you please review it and eventually sign? Thanks.
@giovanni-mocellin, @barvic, @thomreis, @rovere, @eyigitba, @valuev, @missirol, @Martin-Grunewald, @dinyar, @ptcox this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #39228 was updated. @civanch, @epalencia, @clacaputo, @cmsbuild, @rekovic, @mdhildreth, @jpata, @mandrenguyen, @cecilecaillol can you please check and sign again.

@jpata
Copy link
Contributor

jpata commented Aug 29, 2022 •
edited
Loading

Do you also need it for 12_4? Or 12_5 only?
Can you explain a bit the reasoning for backporting to a HI release that should be "closed" (for some value of closed)?

@kakwok
Copy link
Contributor Author

kakwok commented Aug 29, 2022

Hi @jpata , sorry, I was under the impression that 12_5_X is the next release to be used in pp collision at P5.
In any case, this update will also be useful to HI run preparation as we are studying HMT trigger in HI run as well.

@cmsbuild
Copy link
Contributor

Pull request #39228 was updated. @civanch, @epalencia, @clacaputo, @cmsbuild, @rekovic, @mdhildreth, @jpata, @mandrenguyen, @cecilecaillol can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #39228 was updated. @civanch, @epalencia, @clacaputo, @cmsbuild, @rekovic, @mdhildreth, @jpata, @mandrenguyen, @cecilecaillol can you please check and sign again.

@jpata
Copy link
Contributor

jpata commented Aug 30, 2022

@cmsbuild please test

@mandrenguyen
Copy link
Contributor

Hi @jpata , sorry, I was under the impression that 12_5_X is the next release to be used in pp collision at P5. In any case, this update will also be useful to HI run preparation as we are studying HMT trigger in HI run as well.

AFAIK, there is no plan to use 12_5_X for pp data taking. If you want this in for this year's pp data, it would have to also be backported into 12_4_X. Otherwise, it will not be included until 2023 data taking IIUC.

backport of #38941

@kakwok
Copy link
Contributor Author

kakwok commented Aug 30, 2022

@mandrenguyen Thanks, I will prepare a PR for 12_4_X

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1538a8/27191/summary.html
COMMIT: e27b5f3
CMSSW: CMSSW_12_5_X_2022-08-30-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39228/27191/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3695708
  • DQMHistoTests: Total failures: 272
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3695413
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 4 / 50 workflows

@mandrenguyen
Copy link
Contributor

I suggest unifying the title with the master version by changing it to:
Update muon shower (HMT) emulator [12_5_X]

@kakwok kakwok changed the title [12_5_X] Backport of HMT emulation 12 5 X Update muon shower (HMT) emulator [12_5_X] Aug 31, 2022
@kakwok kakwok mentioned this pull request Aug 31, 2022
Merged
@mandrenguyen
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Sep 1, 2022

+1

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Sep 7, 2022

backport of #38941

@rappoccio
Copy link
Contributor

+1

@rappoccio rappoccio merged commit f54db1a into cms-sw:CMSSW_12_5_X Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok fully-signed l1-approved orp-approved reconstruction-approved simulation-approved tests-approved
Projects
None yet
Milestone
CMSSW_12_5_X
Development

Successfully merging this pull request may close these issues.
9 participants
@kakwok @cmsbuild @jpata @mandrenguyen @civanch @cecilecaillol @perrotta @rappoccio @tahuang1991