-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CSC shower data/emulator DQM comparison #38639
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38639/30927
|
A new Pull Request was created by @kakwok for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-131e04/26069/summary.html Comparison SummarySummary:
|
are the differences in wf 11834.0 in L1TEMU caused by your PR understood? |
@emanueleusai The DQM module is comparing unpacked CSC shower digis vs emulator. |
ok understood |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
To enable data/emulator comparison for online DQM, since HMT FW has been deployed at P5.
PR validation:
Ran with run3 cosmic data run351405, plots created is here:
https://cernbox.cern.ch/index.php/s/XmGJ33A1N2BxwGh
Efficiency is 0 because of an additional check on csc id of the shower digi that is not filled by the unpacker.
This will be followed up by another PR.