Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CSC shower data/emulator DQM comparison #38639

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

kakwok
Copy link
Contributor

@kakwok kakwok commented Jul 7, 2022

PR description:

To enable data/emulator comparison for online DQM, since HMT FW has been deployed at P5.

PR validation:

Ran with run3 cosmic data run351405, plots created is here:
https://cernbox.cern.ch/index.php/s/XmGJ33A1N2BxwGh

Efficiency is 0 because of an additional check on csc id of the shower digi that is not filled by the unpacker.
This will be followed up by another PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38639/30927

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2022

A new Pull Request was created by @kakwok for master.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-131e04/26069/summary.html
COMMIT: d8dd726
CMSSW: CMSSW_12_5_X_2022-07-07-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38639/26069/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3654771
  • DQMHistoTests: Total failures: 36
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3654713
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

are the differences in wf 11834.0 in L1TEMU caused by your PR understood?
see: https://tinyurl.com/2qkxxpmy

@kakwok
Copy link
Contributor Author

kakwok commented Jul 8, 2022

@emanueleusai The DQM module is comparing unpacked CSC shower digis vs emulator.
At the moment, the module is comparing emulator against emulator because at the time of the PR, P5 did not have the FW for the CSC shower digi deployed. This PR updates the input collection to use the unpacked digi from data.
I am not sure how useful is this for a MC workflow.

@emanueleusai
Copy link
Member

ok understood

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6494d8f into cms-sw:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants