Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing include for Alpaka CachingAllocator #39067

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Aug 15, 2022

PR description:

GCC 11 IB had a build failure

In file included from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/b88bf8b0f9bf734c61d48d872f44fda5/opt/cmssw/el9_amd64_gcc11/cms/cmssw/CMSSW_12_5_X_2022-08-14-2300/src/HeterogeneousCore/AlpakaInterface/interface/getDeviceCachingAllocator.h:8,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/b88bf8b0f9bf734c61d48d872f44fda5/opt/cmssw/el9_amd64_gcc11/cms/cmssw/CMSSW_12_5_X_2022-08-14-2300/src/HeterogeneousCore/AlpakaServices/src/alpaka/AlpakaService.cc:13:
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/b88bf8b0f9bf734c61d48d872f44fda5/opt/cmssw/el9_amd64_gcc11/cms/cmssw/CMSSW_12_5_X_2022-08-14-2300/src/HeterogeneousCore/AlpakaInterface/interface/CachingAllocator.h:239:12: error: 'optional' in namespace 'std' does not name a template type
   239 |       std::optional<Buffer> buffer;
      |            ^~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/b88bf8b0f9bf734c61d48d872f44fda5/opt/cmssw/el9_amd64_gcc11/cms/cmssw/CMSSW_12_5_X_2022-08-14-2300/src/HeterogeneousCore/AlpakaInterface/interface/getDeviceCachingAllocator.h:8,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/b88bf8b0f9bf734c61d48d872f44fda5/opt/cmssw/el9_amd64_gcc11/cms/cmssw/CMSSW_12_5_X_2022-08-14-2300/src/HeterogeneousCore/AlpakaServices/src/alpaka/AlpakaService.cc:13:
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/b88bf8b0f9bf734c61d48d872f44fda5/opt/cmssw/el9_amd64_gcc11/cms/cmssw/CMSSW_12_5_X_2022-08-14-2300/src/HeterogeneousCore/AlpakaInterface/interface/CachingAllocator.h:5:1: note: 'std::optional' is defined in header '<optional>'; did you forget to '#include <optional>'?
    4 | #include <cassert>
  +++ |+#include <optional>
    5 | #include <exception>

etc https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el9_amd64_gcc11/CMSSW_12_5_X_2022-08-14-2300/HeterogeneousCore/AlpakaServices

This PR adds the missing include.

PR validation:

None (edited on the web)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39067/31572

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

  • HeterogeneousCore/AlpakaInterface (heterogeneous)

@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks.
@rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test for el9_amd64_gcc11

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc1f03/26832/summary.html
COMMIT: 058e6fd
CMSSW: CMSSW_12_5_X_2022-08-14-2300/el9_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39067/26832/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc1f03/26832/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc1f03/26832/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 70378 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3692476
  • DQMHistoTests: Total failures: 466896
  • DQMHistoTests: Total nulls: 396
  • DQMHistoTests: Total successes: 3225162
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4.096 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 1.263 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11834.0 ): 0.907 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.111 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.075 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 1.740 KiB SiStrip/MechanicalView
  • Checked 212 log files, 49 edm output root files, 51 DQM output files

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc1f03/26837/summary.html
COMMIT: 058e6fd
CMSSW: CMSSW_12_5_X_2022-08-15-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39067/26837/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc1f03/26837/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc1f03/26837/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3692476
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3692446
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor

fwyzard commented Aug 16, 2022

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 380a88d into cms-sw:master Aug 16, 2022
@makortel makortel deleted the patch-5 branch August 16, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants