Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the delay of the CPPF DAQ data for backport to 12_4_X #38979

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

mileva
Copy link
Contributor

@mileva mileva commented Aug 5, 2022

PR description:

To fix the CPPF DAQ delay and RPC offline clusters BX association.

PR validation:

Tested with:
runTheMatrix and three different workflows:
136.897 RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3
1001.3 RunSingleMuon2022B+TIER0EXPRUN3+ALCAEXPRUN3+ALCAHARVDEXPRUN3

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Yes, this is a backport - PR to master #38974
This RP is a replica of the closed one #38975 but rebased to the 12_4_X

mention @dilsonjd @jhgoh @andresib

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2022

A new Pull Request was created by @mileva for CMSSW_12_4_X.

It involves the following packages:

  • EventFilter/RPCRawToDigi (reconstruction)

@jpata, @cmsbuild, @clacaputo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mileva mileva mentioned this pull request Aug 5, 2022
@jpata
Copy link
Contributor

jpata commented Aug 8, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2022

Pull request #38979 was updated. @jpata, @cmsbuild, @clacaputo can you please check and sign again.

@jpata
Copy link
Contributor

jpata commented Aug 9, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-810ac1/26721/summary.html
COMMIT: d545cc0
CMSSW: CMSSW_12_4_X_2022-08-09-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38979/26721/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 33 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3677242
  • DQMHistoTests: Total failures: 297
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3676922
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@jpata
Copy link
Contributor

jpata commented Aug 11, 2022

+reconstruction

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 12, 2022

+1

@cmsbuild cmsbuild merged commit d69804c into cms-sw:CMSSW_12_4_X Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants