Fix the delay of the CPPF DAQ data #38974

mileva · 2022-08-05T12:22:52Z

PR description:

To fix the CPPF DAQ delay and RPC offline clusters BX association.

PR validation:

Tested with:
runTheMatrix and three different workflows:
136.897_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3
140.103_RunSingleMuon2022B+RunSingleMuon2022B+HLTRUN3+RECONANORUN3+SKIMSINGLEMUONRUN3
140.117_RunCosmics2022B+RunCosmics2022B+HLTRUN3+RECOCOSMRUN3+SKIMCOSMICSRUN3

And also with private validation and offline analysis.

More details and validation plots might be found here.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

None, to be backported in 12_4_X

Mention @dilsonjd @jhgoh @andresib

cmsbuild · 2022-08-05T12:32:07Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38974/31428

This PR adds an extra 16KB to repository

cmsbuild · 2022-08-05T12:32:31Z

A new Pull Request was created by @mileva for master.

It involves the following packages:

EventFilter/RPCRawToDigi (reconstruction)

@jpata, @cmsbuild, @clacaputo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

jpata · 2022-08-05T14:14:22Z

EventFilter/RPCRawToDigi/plugins/RPCCPPFUnpacker.cc

@@ -217,7 +220,7 @@ void RPCCPPFUnpacker::processRXRecord(RPCAMCLink link,
    return;
  }

-  if (bx < bx_min || bx > bx_max) {
+  if ((bx - cppfDaq_Delay) < bx_min || (bx - cppfDaq_Delay) > bx_max) {


wouldn't it make sense to define e.g.

auto bx_corrected = bx - cppfDaq_Delay;

and use it everywhere where the shifted value must be used? does the meaning of bx==0 change or stay the same (e.g. a few lines below here)?

Thanks @jpata

does the meaning of bx==0 change or stay the same
Good question! It looks that is needed for the DPG analysis, but could be deeper. Let me have some time to debug and investigate.

auto bx_corrected implemented as suggested.

Hi @jpata !
I have updated #38979, as well.

On the question "does the meaning of bx==0 change or stay the same".
I checked and it does change nothing both in the CPPF DAQ data (attached cppf_rpc_daq_bx_check.png) or in the input to EMTF (l1_L1Stage2EMTF_rpcHitBX.png).
So, we would prefer to not touch it for the moment.

In order to test I used 136.897_RunCosmics2021CRUZET workflow, but I changed the input data. The default run for this workflow is 344518, however in this run the CPPF key were not enabled to EMTF. (I.e. - no RPC input to EMTF, just DAQ data.) Because of this I changed with another cosmics run 356088.
runTheMatrix test ran without problems.

However, I decided to run with more events - the default are 100 events.
And on the 102th event the Module: L1TStage2CPPF:l1tStage2Cppf crashed with segmentation violation.
But I don't think the crash is caused of our update,
as the same module already was reported to crash with release validation after it was already merged, further to latest comments in #38564 .
ping @ram1123 and @zhangcg123

I can give more details during the meeting.

jpata · 2022-08-05T14:20:07Z

@cmsbuild please test

cmsbuild · 2022-08-05T18:12:15Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3adec0/26653/summary.html
COMMIT: b900afa
CMSSW: CMSSW_12_5_X_2022-08-05-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38974/26653/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 29 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3691612
DQMHistoTests: Total failures: 318
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3691271
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

cmsbuild · 2022-08-08T14:14:56Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38974/31464

This PR adds an extra 16KB to repository

cmsbuild · 2022-08-08T14:15:21Z

Pull request #38974 was updated. @jpata, @cmsbuild, @clacaputo can you please check and sign again.

jpata · 2022-08-09T10:37:31Z

@cmsbuild please test

cmsbuild · 2022-08-09T14:35:46Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3adec0/26720/summary.html
COMMIT: 70f4195
CMSSW: CMSSW_12_5_X_2022-08-09-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38974/26720/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 27 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3692476
DQMHistoTests: Total failures: 313
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3692141
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

mileva · 2022-08-09T14:36:18Z

Hi @dilsonjd , @jpata , @zhangcg123
I checked once again with the latest IB, applying the same changes as proposed in this PR - now there is no segmentation violation in the Module: L1TStage2CPPF:l1tStage2Cppf.
Roumyana

jpata · 2022-08-10T11:32:27Z

I checked once again with the latest IB, applying the same changes as proposed in this PR - now there is no segmentation violation in the Module: L1TStage2CPPF:l1tStage2Cppf.

Sorry I missed the point here - what is the segfault you are talking about?

We can see some differences in RPC distributions

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_5_X_2022-08-09-1100+3adec0/52044/validateJR/all_OldVSNew_RunMinimumBias2021wf139p001/all_OldVSNew_RunMinimumBias2021wf139p001c_RPCDetIdRPCRecHitsOwnedRangeMap_rpcRecHits__reRECO_objAT_size.png

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_5_X_2022-08-09-1100+3adec0/52044/validateJR/all_OldVSNew_RunMinimumBias2021wf139p001/all_OldVSNew_RunMinimumBias2021wf139p001c_RPCDetIdRPCRecHitsOwnedRangeMap_rpcRecHits__reRECO_obj_collection__data__localPosition_x.png

which I understand are expected. Surprisingly nothing in muons downstream (too rare?).

I think enabling this change with the Run3_RPC modifier seems reasonable, if it's not planned for Run2 or Phase2.

Are there any studies left you want to do here or is this PR ready?

mileva · 2022-08-10T12:02:34Z

Hi @jpata
There was a segmentation fault caused by the fact I was testing with an old integration build (before the merge of the L1 DQM CPPF module #38564 ), pulling the branch from Dilson, which was created later on. For that period there were another changes in the RPCCPPF unpacker, for which we were not aware. After moving the tests to the latest IB - there were no longer segmentation violation. Sorry, if I introduced some "noise".

About the MinBias - validation plots: Yes, the changes are expected. As a consequence of the "delayed" daq data some of the offline rpc clusters in the endcap were not reconstructed and thus not stored in the data.
And in the same time some "yearly coming" digis (with respect to the usual readout) were propagated. So, I think the comparison plots are correct.

About the muons: in general there are not too much muons in the MinBias data. From the other hand the RPC rechits are not widely used in the reconstruction, but rather for the the timing studies.

Modification is for Run3. We do not need this for Run2 and we don't have plan to explore it in phase 2.

I don't think we can make some more studies at this moment and I would like to ask to approve this pull request.

Thank you!
Roumyana

jpata · 2022-08-11T13:41:48Z

+reconstruction

bugfix for RPC datataking
affects RPC quantities in data for Run3 (may have effects on muons downstream)

cmsbuild · 2022-08-11T13:42:12Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

jpata · 2022-08-11T13:43:02Z

@mileva can you please edit the title to be the same as you used for the 12_4_X version of this PR? That one is a lot more descriptive.

jpata · 2022-08-11T14:53:03Z

just to clarify, you can remove 12_4_X from the title :)

qliphy · 2022-08-11T15:12:29Z

+1

mileva and others added 3 commits August 2, 2022 15:32

fix the delay of the CPPF DAQ data

1f8fd6c

fix the CPPF DAQ delay and style update

3e6fdc2

using run3_RPC to fix the CPPF DAQ delay

b900afa

cmsbuild added this to the CMSSW_12_5_X milestone Aug 5, 2022

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Aug 5, 2022

mileva mentioned this pull request Aug 5, 2022

Mileva/cppf delay fix v0 #38975

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 5, 2022

jpata reviewed Aug 5, 2022

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Aug 5, 2022

mileva mentioned this pull request Aug 5, 2022

fix the delay of the CPPF DAQ data for backport to 12_4_X #38979

Merged

cmsbuild added tests-approved and removed tests-started labels Aug 5, 2022

corrected bx with cppfDaqDelay

70f4195

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels Aug 8, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 8, 2022

cmsbuild added tests-started and removed tests-pending labels Aug 9, 2022

cmsbuild added tests-approved and removed tests-started labels Aug 9, 2022

qliphy mentioned this pull request Aug 10, 2022

Out of range exception from RPCAMCRawToDigi #38939

Closed

cmsbuild added fully-signed reconstruction-approved and removed reconstruction-pending pending-signatures labels Aug 11, 2022

mileva changed the title ~~Mileva/cppf delay fix v0~~ Fix the delay of the CPPF DAQ data for backport to 12_4_X Aug 11, 2022

qliphy changed the title ~~Fix the delay of the CPPF DAQ data for backport to 12_4_X~~ Fix the delay of the CPPF DAQ data Aug 11, 2022

cmsbuild added orp-approved and removed orp-pending labels Aug 11, 2022

cmsbuild merged commit 4600eda into cms-sw:master Aug 11, 2022

cmsbuild mentioned this pull request Aug 12, 2022

Update PU for Run3 wfs #39041

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the delay of the CPPF DAQ data #38974

Fix the delay of the CPPF DAQ data #38974

mileva commented Aug 5, 2022

cmsbuild commented Aug 5, 2022

cmsbuild commented Aug 5, 2022

jpata Aug 5, 2022 •

edited

Loading

mileva Aug 5, 2022

dilsonjd Aug 8, 2022

mileva Aug 9, 2022 •

edited

Loading

jpata commented Aug 5, 2022

cmsbuild commented Aug 5, 2022

cmsbuild commented Aug 8, 2022

cmsbuild commented Aug 8, 2022

jpata commented Aug 9, 2022

cmsbuild commented Aug 9, 2022

mileva commented Aug 9, 2022

jpata commented Aug 10, 2022

mileva commented Aug 10, 2022

jpata commented Aug 11, 2022

cmsbuild commented Aug 11, 2022

jpata commented Aug 11, 2022 •

edited

Loading

jpata commented Aug 11, 2022

qliphy commented Aug 11, 2022

Fix the delay of the CPPF DAQ data #38974

Fix the delay of the CPPF DAQ data #38974

Conversation

mileva commented Aug 5, 2022

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Aug 5, 2022

cmsbuild commented Aug 5, 2022

jpata Aug 5, 2022 • edited Loading

Choose a reason for hiding this comment

mileva Aug 5, 2022

Choose a reason for hiding this comment

dilsonjd Aug 8, 2022

Choose a reason for hiding this comment

mileva Aug 9, 2022 • edited Loading

Choose a reason for hiding this comment

jpata commented Aug 5, 2022

cmsbuild commented Aug 5, 2022

Comparison Summary

cmsbuild commented Aug 8, 2022

cmsbuild commented Aug 8, 2022

jpata commented Aug 9, 2022

cmsbuild commented Aug 9, 2022

Comparison Summary

mileva commented Aug 9, 2022

jpata commented Aug 10, 2022

mileva commented Aug 10, 2022

jpata commented Aug 11, 2022

cmsbuild commented Aug 11, 2022

jpata commented Aug 11, 2022 • edited Loading

jpata commented Aug 11, 2022

qliphy commented Aug 11, 2022

jpata Aug 5, 2022 •

edited

Loading

mileva Aug 9, 2022 •

edited

Loading

jpata commented Aug 11, 2022 •

edited

Loading