[124X] Fix for nan in loc angle backport

[tvami]

PR description:

See #38881

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #38881

[tvami]

type bugfix,trk

[tvami]

backport of #38881

[cmsbuild]

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_4_X.

It involves the following packages:

• CondFormats/SiPixelTransient (db, reconstruction)

@malbouis, @clacaputo, @cmsbuild, @ggovi, @jpata, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@VinInn, @OzAmram, @ferencek, @mmusich, @dkotlins, @seemasharmafnal, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Check for nans earlier in the template reco #38881

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-82fc13/26529/summary.html
COMMIT: 5341c8a
CMSSW: CMSSW_12_4_X_2022-07-29-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38895/26529/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3676198
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3676168
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tvami]

+db

[clacaputo]

+reconstruction

• backport of Check for nans earlier in the template reco #38881 , code in line with the original PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[fabiocos]

@qliphy @perrotta this PR seems to solve new crashes that we are observing at Tier0. It would be useful to clarify the path for its insertion into a (patch)-release which can be deployed. I did not see issues triggered by it in the IBs after its merge.

[qliphy]

@qliphy @perrotta this PR seems to solve new crashes that we are observing at Tier0. It would be useful to clarify the path for its insertion into a (patch)-release which can be deployed. I did not see issues triggered by it in the IBs after its merge.

@fabiocos Yes, there are several PRs requested for next 12_4_X, let's discuss the plan at today's ORP.