Check for nans earlier in the template reco

[tvami]

PR description:

Resolves #38869 by moving the protection of nan-s earlier in the code.

PR validation:

The job in #38869 (comment) run successfully.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Needs to go back to 12_4_X

[tvami]

type bugfix,trk

[tvami]

test parameters:

• enable_tests = profiling

[tvami]

I assume we'd like to see the performance change, right? #38881 (comment)

[mmusich]

I assume we'd like to see the performance change, right? #38881 (comment)

I initially misunderstood the code and interpreted that the check was done only in the standalone case, but it's actually the other way around (it is checked in the cmssw job but not in the standalone pixelAV simulation), so performance should not be a concern (if anything few more instructions should be skipped).

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38881/31310

• This PR adds an extra 44KB to repository

[cmsbuild]

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

• CondFormats/SiPixelTransient (db, reconstruction)

@malbouis, @clacaputo, @cmsbuild, @ggovi, @jpata, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@VinInn, @OzAmram, @ferencek, @mmusich, @dkotlins, @seemasharmafnal, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75ace1/26505/summary.html
COMMIT: 8bb9eb0
CMSSW: CMSSW_12_5_X_2022-07-28-1100/el8_amd64_gcc10
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38881/26505/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 14 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3668050
• DQMHistoTests: Total failures: 20
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3668008
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 210 log files, 47 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[tvami]

urgent

• backport needed for data-taking

[clacaputo]

+reconstruction

• fix Segmentation fault in the TrackProducer for EphemeralHLTPhysics #38869
• successfully tested

[tvami]

+db

• signing for myself just because of the urgency
• anyway tests pass, PR is in line with the description

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1