Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Save EDMNANO in EcalPhiSymRecoSequence #38836

Merged
merged 1 commit into from
Jul 24, 2022

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Jul 22, 2022

PR description:

See #38835

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #38835

@cmsbuild cmsbuild added this to the CMSSW_12_4_X milestone Jul 22, 2022
@tvami tvami changed the title save_edmnano in EcalPhiSymRecoSequence [12_4_X] Save EDMNANO in EcalPhiSymRecoSequence Jul 22, 2022
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_4_X.

It involves the following packages:

  • Calibration/EcalCalibAlgos (alca)

@malbouis, @yuanchao, @cmsbuild, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@rchatter, @tocheng, @argiro, @thomreis, @simonepigazzini, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Jul 22, 2022

test parameters:

  • workflows = 139.005

@tvami
Copy link
Contributor Author

tvami commented Jul 22, 2022

type ecal,bugfix

@tvami
Copy link
Contributor Author

tvami commented Jul 22, 2022

urgent

  • should go into 12_4_4

@tvami
Copy link
Contributor Author

tvami commented Jul 22, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e056eb/26403/summary.html
COMMIT: 590f263
CMSSW: CMSSW_12_4_X_2022-07-22-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38836/26403/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e056eb/139.005_AlCaPhiSym2021+AlCaPhiSym2021+RECOALCAECALPHISYMDR3+ALCAECALPHISYM

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676198
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3676168
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 211 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@ChrisMisan
Copy link
Contributor

+alca

  • backport
  • wf 139.005 passes
  • differences only in msgLogger and MTD

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • Merged in master since CMSSW_12_5_X_2022-07-24-0000

@cmsbuild cmsbuild merged commit f56604f into cms-sw:CMSSW_12_4_X Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants