-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save EDMNANO in EcalPhiSymRecoSequence #38835
Conversation
test parameters:
|
type ecal,bugfix |
@cmsbuild , please test |
urgent
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38835/31218
|
A new Pull Request was created by @tvami (Tamas Vami) for master. It involves the following packages:
@malbouis, @tvami, @yuanchao, @ChrisMisan, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-598197/26404/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Follow-up to dmwm/T0#4664
The EDMNANO files were empty, this PR changes the costumization so it saves the EDMNANO output.
PR validation:
gives the correct EDMNANO content, verified by the experts @simonepigazzini
I also ran
runTheMatrix.py -l 139.005
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Need to backport to 12_4_X