-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Geometry_cff with GeometryDB_cff in RecoJets #38784
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38784/31134
|
A new Pull Request was created by @jeongeun (JeongEun Lee) for master. It involves the following packages:
@jpata, @cmsbuild, @clacaputo can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aeabb4/26328/summary.html Comparison SummarySummary:
|
@@ -42,7 +42,7 @@ | |||
|
|||
process = cms.Process("Ana") | |||
process.load('Configuration.StandardSequences.FrontierConditions_GlobalTag_cff') | |||
process.load("Configuration.StandardSequences.Geometry_cff") | |||
process.load("Configuration.StandardSequences.GeometryDB_cff") | |||
process.GlobalTag.globaltag = GLOBAL_TAG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jeongeun GLOBAL_TAG
is initialized with old GT; moreover, the input files used are from 2010.
Did you try to run it? Maybe we can directly remove this?
@cms-sw/jetmet-pog-l2 , what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cms-sw/jetmet-pog-l2 , any thoughts about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @laurenhay could you please check whether these cfgs are still needed by jme people? Thanks
kind ping @cms-sw/jetmet-pog-l2 @laurenhay |
@jpata is this for us or for JME? |
sorry it was for @cms-sw/jetmet-pog-l2 (Lauren is on double duty and I got confused). |
Hi @laurenhay , any update on the other files? Thanks |
A kindly ping to @laurenhay |
Hey @clacaputo sorry for the delay I think the consensus is they can go. |
Thanks for checking. @jeongeun could you please remove them? |
sorry for replying late - JME has no objections |
Kindly ping @jeongeun |
Pull request #38784 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38784/32744
|
Pull request #38784 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aeabb4/28513/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
There are some differences in JetMET folder of DMQ bin-by-bin comparison for wf |
Update: it seems to be a widespread issue |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Review on the Reco part of #31113
process.load("Configuration.StandardSequences.Geometry_cff")
was outdated #8810
It should be replaced with
process.load("Configuration.StandardSequences.GeometryDB_cff")
In this PR, RecoJets configuration files (4 files) are fixed.
PR validation:
Tested in CMSSW_12_5_X, the basic test all passed in the CMSSW PR instructions