Fix conddb dump functionality for tags and gts

[francescobrivio]

PR description:

In PR #20215 a new required argument (destFile) was added to the payload2xml function in CondCore/Utilities/python/cond2xml.py and a new argument (--destfile) was added to conddb dump.
In conddb there are 3 calls of payload2xml: one for the payload type, one for the tag type and one for the gt type;
but the default value of destFile was only passed to the payload-call and not to the other two, causing an error of type:

ERROR: payload2xml() missing 1 required positional argument: 'destFile'

This PR adds the default value also to the other two calls.

At the same time the command conddb dump for the gt type was failing also with error:

ERROR: type object 'GlobalTag' has no attribute 'name'

This is also resolved by fixing a correctly passing the GT name when invoking the _exists function in conddb.

PR validation:

With these changes the following commands work properly:

• conddb dump --type tag SiPixelQuality_byPCL_stuckTBM_v1
• conddb dump --type gt 123X_mcRun1_design_v1

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, a backport to 12_4_X might be considered later on

[francescobrivio]

@ggovi I'd like your feedback on this as I might be missing something here: it seems strange to me that nobody ever noticed this issue so far (altough I must admit I myself have only used the conddb dump --type payload up till now...).

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38757/31077

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

• CondCore/Utilities (db)

@cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

Would you mind adding the newly functioning commands to the unit test?
https://github.com/cms-sw/cmssw/blob/master/CondCore/Utilities/test/test_conddb.sh

[francescobrivio]

type bug-fix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38757/31112

• This PR adds an extra 44KB to repository

[cmsbuild]

Pull request #38757 was updated. @cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please check and sign again.

[francescobrivio]

@cmsbuild please test

[francescobrivio]

@cmsbuild please abort

• more unitTests will be added

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38757/31113

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #38757 was updated. @ggovi, @malbouis, @tvami, @francescobrivio can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3db343/26305/summary.html
COMMIT: 948d599
CMSSW: CMSSW_12_5_X_2022-07-18-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38757/26305/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3662417
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3662387
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tvami]

The unit test seems to be successful:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3db343/26305/unitTests/src/CondCore/Utilities/test/test_conddb/testing.log

[francescobrivio]

The PR is good now, @ggovi please let us know what you think of this when you can.

[tvami]

+db

• discussing privetally with @ggovi he agrees with the fix provided in the PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1