Improvements for conddb dump command #20215

ggovi · 2017-08-21T09:49:34Z

Goals of this PR:

Allow the usage of a library ( part of CMSSW release ) with built-in XML converters for specific payload classes. The payloads whose the XML dump is more frequent are belonging to this category. For the moment, only the RunInfo condFormat class has been added. Further addition will be addressed with specific PR by the owners of the concerned CondFormats. Only a one-line change PR is required for any addition.
Smoothen the XML conversion for payload classes NOT present in the built-in library. A single plugin library is generated locally by the command, per payload type. Once generated, the plugin library is kept for further usage, speeding up considerably the execution of multiple command requests.

… re-use of locally generated libraries with xml converters

cmsbuild · 2017-08-21T09:49:54Z

A new Pull Request was created by @ggovi for master.

It involves the following packages:

CondCore/Utilities

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

ggovi · 2017-08-21T09:50:41Z

please test

cmsbuild · 2017-08-21T09:50:56Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22393/console Started: 2017/08/21 11:51

cmsbuild · 2017-08-21T09:53:21Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20215/219

cmsbuild · 2017-08-21T11:20:36Z

+1
Tested at: 679ddaa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20215/22393/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1f919e0
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20215/22393/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20215/22393/git-merge-result

cmsbuild · 2017-08-21T11:20:39Z

Comparison job queued.

cmsbuild · 2017-08-21T11:34:54Z

Pull request #20215 was updated. @ggovi, @cmsbuild can you please check and sign again.

ggovi · 2017-08-21T11:35:04Z

please test

cmsbuild · 2017-08-21T11:35:07Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22394/console Started: 2017/08/21 13:35

cmsbuild · 2017-08-21T11:36:46Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20215/220

cmsbuild · 2017-08-21T11:41:02Z

-1

Tested at: 75db869

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1f919e0
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20215/22394/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20215/22394/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20215/22394/summary.html

I found follow errors while testing this PR

Failed tests: Build

Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-20-2300/src/CondCore/EcalPlugins/plugins/EcalPyUtils.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-20-2300/src/CondCore/EcalPlugins/plugins/EcalCondObjectContainer_EcalTPGCrystalStatusCode_toXML.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-20-2300/src/CondCore/EcalPlugins/plugins/EcalChannelStatus_PayloadInspector.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-20-2300/src/CondCore/EcalPlugins/plugins/EcalPedestals_PayloadInspector.cc 
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-20-2300/src/CondCore/EcalPlugins/plugins/EcalCondObjectContainer_EcalTPGCrystalStatusCode_toXML.cc:2:0:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-20-2300/poison/CondCore/Utilities/interface/PayloadToXML.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
  ^~~~~
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-20-2300/src/CondCore/SiStripPlugins/test/testSiStripPayloadInspector.cpp 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-20-2300/src/CondCore/SiStripPlugins/src/plugin.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-20-2300/src/CondCore/SiStripPlugins/plugins/SiStripDetVOff_PayloadInspector.cc

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1f919e0
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20215/22394/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20215/22394/git-merge-result

cmsbuild · 2017-08-21T11:41:05Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2017-08-28T14:18:42Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-08-28T14:18:42Z

Pull request #20215 was updated. @ggovi, @cmsbuild can you please check and sign again.

ggovi · 2017-08-28T14:19:05Z

please test

cmsbuild · 2017-08-28T14:19:20Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22524/console Started: 2017/08/28 16:20

cmsbuild · 2017-08-28T14:20:45Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20215/349

cmsbuild · 2017-08-28T15:56:56Z

+1
Tested at: 0d5f27e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20215/22524/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
566f40c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20215/22524/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20215/22524/git-merge-result

cmsbuild · 2017-08-28T15:56:59Z

Comparison job queued.

cmsbuild · 2017-08-28T16:43:48Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20215/22524/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2653934
DQMHistoTests: Total failures: 205
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2653540
DQMHistoTests: Total skipped: 189
DQMHistoTests: Total Missing objects: 0
Checked 107 log files, 14 edm output root files, 26 DQM output files

ggovi · 2017-08-28T17:06:12Z

+1

cmsbuild · 2017-08-28T17:06:29Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

davidlange6 · 2017-08-29T06:22:26Z

+1

ggovi added 2 commits August 18, 2017 17:58

Improvements for: handling of xml converters from built-in libraries;…

bcd76c9

… re-use of locally generated libraries with xml converters

Added forgotten file...

679ddaa

cmsbuild added this to the CMSSW_9_3_X milestone Aug 21, 2017

cmsbuild added comparison-pending db-pending orp-pending pending-signatures tests-pending labels Aug 21, 2017

cmsbuild added tests-started and removed tests-pending labels Aug 21, 2017

cmsbuild added tests-approved and removed tests-started labels Aug 21, 2017

Removed forgotten file...

75db869

cmsbuild added tests-pending and removed tests-approved labels Aug 21, 2017

cmsbuild added tests-started and removed tests-pending labels Aug 21, 2017

cmsbuild removed the comparison-pending label Aug 21, 2017

cmsbuild added orp-pending pending-signatures tests-pending labels Aug 28, 2017

cmsbuild added tests-started and removed tests-pending labels Aug 28, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 28, 2017

cmsbuild added tests-approved and removed tests-started labels Aug 28, 2017

cmsbuild added comparison-available and removed comparison-pending labels Aug 28, 2017

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Aug 28, 2017

cmsbuild added orp-approved and removed orp-pending labels Aug 29, 2017

cmsbuild merged commit 338287d into cms-sw:master Aug 29, 2017

francescobrivio mentioned this pull request Jul 15, 2022

Fix conddb dump functionality for tags and gts #38757

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improvements for conddb dump command #20215

Improvements for conddb dump command #20215

ggovi commented Aug 21, 2017 •

edited

Loading

cmsbuild commented Aug 21, 2017

ggovi commented Aug 21, 2017

cmsbuild commented Aug 21, 2017 •

edited

Loading

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

ggovi commented Aug 21, 2017

cmsbuild commented Aug 21, 2017 •

edited

Loading

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

ggovi commented Aug 28, 2017

cmsbuild commented Aug 28, 2017 •

edited

Loading

cmsbuild commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

ggovi commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

davidlange6 commented Aug 29, 2017

Improvements for conddb dump command #20215

Improvements for conddb dump command #20215

Conversation

ggovi commented Aug 21, 2017 • edited Loading

cmsbuild commented Aug 21, 2017

ggovi commented Aug 21, 2017

cmsbuild commented Aug 21, 2017 • edited Loading

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

ggovi commented Aug 21, 2017

cmsbuild commented Aug 21, 2017 • edited Loading

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 21, 2017

cmsbuild commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

ggovi commented Aug 28, 2017

cmsbuild commented Aug 28, 2017 • edited Loading

cmsbuild commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

ggovi commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

davidlange6 commented Aug 29, 2017

ggovi commented Aug 21, 2017 •

edited

Loading

cmsbuild commented Aug 21, 2017 •

edited

Loading

cmsbuild commented Aug 21, 2017 •

edited

Loading

cmsbuild commented Aug 28, 2017 •

edited

Loading