Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sigmaietaieta caloID cut to the Run 3 scouting electron path backport from CMSSW_12_5_X #38720

Merged

Conversation

arsahasransu
Copy link
Contributor

Co-authored-by: Marino Missiroli [email protected]

PR description:

Add the sigmaietaieta calo id variable cut to the Run 3 scouting electron collection

  • Use the same cut strategy as in the standard electron path.
  • Default value is kept so that all the electrons pass without the cut.
  • Default implementation is "less than" a certain cut value because the standard use of this variable is var < cut.
  • Validated in presentation in the scouting group at https://indico.cern.ch/event/1174315/#1-update-on-scouting-electrons
  • The EGamma sigmaietaieta variable will be updated with sigmaietaieta(noisecleaned) variable which can be done as a different collection input to the same variable to that has been left unchanged but will be part of the changes to the scouting path.

PR validation:

To validate the changes in this PR

  • We re-emulated the scouting path with MC and 2018 data files.
  • Timing and Rate studies were done as well to see if the effect of the PR is as expected.
  • All observations were found to be normal.
  • In addition, all the regular set of checks such as code-check and code-formatting suggested in CMSSW PR instructions have also been applied.

PR backport from CMSSW_12_5_X to CMSSW_12_4_X:

The current online HLT for Run 3 is running on the 12_4_X release cycle. This PR introduces the sigmaietaieta_noisecleaned variable cut in the Run 3 Scouting EGamma HLT path.
Master PR: #38602
Intended backport release cycle number: CMSSW_12_4_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 13, 2022

A new Pull Request was created by @arsahasransu (A.R.Sahasransu) for CMSSW_12_4_X.

It involves the following packages:

  • HLTrigger/Egamma (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@arsahasransu arsahasransu changed the title Add sigmaietaieta caloID cut to the Run 3 scouting electron path Add sigmaietaieta caloID cut to the Run 3 scouting electron path backport from CMSSW_12_5_X Jul 13, 2022
@missirol
Copy link
Contributor

backport of #38602

@missirol
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c3cb9/26198/summary.html
COMMIT: 4f63c05
CMSSW: CMSSW_12_4_X_2022-07-12-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38720/26198/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676111
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3676081
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 14, 2022

+1

@cmsbuild cmsbuild merged commit b2222a7 into cms-sw:CMSSW_12_4_X Jul 14, 2022
@arsahasransu arsahasransu deleted the checkEgammaCutforScouting125X_124X branch July 14, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants