-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EGamma calo ID variable cut to Run 3 Scouting Electrons #38602
Add EGamma calo ID variable cut to Run 3 Scouting Electrons #38602
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38602/30877
|
A new Pull Request was created by @arsahasransu (A.R.Sahasransu) for master. It involves the following packages:
@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
23e8af3
to
0ee4e45
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38602/30903
|
Pull request #38602 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d5bcf/26014/summary.html Comparison SummarySummary:
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38602/30916
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
Co-authored-by: Marino Missiroli <[email protected]>
3b3c246
to
a773959
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38602/30979
|
Pull request #38602 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again. |
please test |
It sounds like this PR will be followed by a JIRA ticket to make changes to the Scouting Path for the ongoing pp data-taking, which will use |
@missirol Yes, indeed! Thanks for the suggestion. I was planning to do that. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d5bcf/26182/summary.html Comparison SummarySummary:
|
+hlt |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Co-authored-by: Marino Missiroli [email protected]
PR description:
Add the sigmaietaieta calo id variable cut to the Run 3 scouting electron collection
PR validation:
To validate the changes in this PR
Based on comments from Marino Missiroli [email protected] in a previous version of the PR some changes have already been included. The old PR, which is now closed can be found at #38597.