Phase2-hgx316D Add the validation code created by Indranil Das for muon tomography test of HGCal Geometry

[bsunanda]

PR description:

Add the validation code created by Indranil Das for muon tomography test of HGCal Geometry

It needs cms-data/Validation-HGCalValidation#4 and cms-data/Validation-HGCalValidation#5 to run the (so far private) tests implemented here

PR validation:

Use the code privately by adding files in the area Validation/HGCalValidation/data. A separate PR is made to add 2 files in the CMS Data area which will be required to repeat the test in the public version

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38577/30824

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38577/30824/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38577/30824/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38577/30826

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Validation/HGCalValidation (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @rovere, @lgray, @cseez, @apsallid, @pfs, @lecriste, @hatakeyamak, @ebrondol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f8fb62/25931/summary.html
COMMIT: 8f791a6
CMSSW: CMSSW_12_5_X_2022-06-30-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38577/25931/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3654771
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3654747
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

Use the code privately by adding files in the area Validation/HGCalValidation/data. A separate PR is made to add 2 files in the CMS Data area which will be required to repeat the test in the public version

Could a unit test be added to Validation/HGCalValidation, so that once those new files in Validation/HGCalValidation/data are linked as externals the new code can be automatically tested by bot at every release (or at least for these PR tests)?

[bsunanda]

We are working on a unit test. But first we need a new cms-data with PR's #4 and #5 integrated

[bsunanda]

@perrotta Please accept this PR and we shall create a unit test soon after the new cms-data

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38577/31133

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #38577 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[indra-ehep]

@indra-ehep @Pruthvi-ch This time the file is readable. Can you add one more file for V16 in the Extended2026D88 directory>

@bsunanda We have managed to put one for v16 but we have the step1.root for D86 not D88.

[indra-ehep]

/eos/cms/store/group/dpg_hgcal/

@pfs This is indeed very helpful. We can keep some shared file there. Do you have any predefined path to keep the geometry related files ? Or we should create a path under /eos/cms/store/group/dpg_hgcal/ according to the requirement of geometry workflow ?

[pfs]

@indra-ehep I suggest to create a geometry directory under /eos/cms/store/group/dpg_hgcal/comm_hgcal/

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f8fb62/26325/summary.html
COMMIT: 1d10769
CMSSW: CMSSW_12_5_X_2022-07-19-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38577/26325/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3662417
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3662381
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[emanueleusai]

so are you planning to move the files to /eos/cms/store/group/dpg_hgcal/comm_hgcal/ or are you keeping them in /eos/user/i/idas/SimOut/DeltaPt/ ?

[indra-ehep]

so are you planning to move the files to /eos/cms/store/group/dpg_hgcal/comm_hgcal/ or are you keeping them in /eos/user/i/idas/SimOut/DeltaPt/ ?

@emanueleusai For this PR we do not plan change the path, since in next PR we plan to add a script which will create the step1.root and the requirement to access path /eos/user/i/idas/SimOut/DeltaPt/ will be no longer required (also discussed above with @perrotta ). However, we are benefited to have access of /eos/cms/store/group/dpg_hgcal/comm_hgcal/, any file which are of common interest will be kept there.

If the idea is also acceptable to you and there is no further query I request you to approve for dqm.
I also request @perrotta for orp approval if there is no other concern.
Once the current PR is merged with head, we plan to proceed for next update on Muon Tomography of HGCAL.

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1