Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wfs to test Run3 skims #38830

Merged
merged 9 commits into from
Jul 26, 2022
Merged

Add wfs to test Run3 skims #38830

merged 9 commits into from
Jul 26, 2022

Conversation

kskovpen
Copy link
Contributor

PR description:

Add Run3 skims to the standard relval wfs. The following wfs are added: 140.103-140.118.

PR validation:

Tested on the aforementioned wfs. At the moment, the wfs that run on 2022B (140.105, 140.110, 140.112, 140.113, 140.117, 140.118) will fail in the tests because of the issue at the HLT step. Maybe @cms-sw/hlt-l2 will have an idea what is wrong with the configuration (HLT:relval2022 is used, which should correspond to GRun) when using 2022B data. Alternatively, we can switch to fake HLT when testing these wfs.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR will be back ported to 12_4_X.

FYI: @sam7k9621 @cms-sw/alca-l2 @bbilin @rappoccio @jmartinb

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38830/31202

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kskovpen for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@kskovpen
Copy link
Contributor Author

test parameters:

  • workflows = 140.001,140.002,140.103,140.104,140.105,140.106,140.107,140.108,140.109,140.110,140.111,140.112,140.113,140.114,140.115,140.116,140.117,140.118
  • relvals_opt = -w standard

@kskovpen
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89f107/26392/summary.html
COMMIT: 51292ce
CMSSW: CMSSW_12_5_X_2022-07-21-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38830/26392/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89f107/26392/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89f107/26392/git-merge-result

RelVals

  • 140.103DAS Error
  • 140.105DAS Error
  • 140.106DAS Error
Expand to see more relval errors ...
  • 140.107
  • 140.108
  • 140.109
  • 140.11
  • 140.111
  • 140.112
  • 140.113
  • 140.114
  • 140.115
  • 140.116
  • 140.117
  • 140.118

RelVals-INPUT

AddOn Tests

----- Begin Fatal Exception 22-Jul-2022 10:58:29 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'L1TAnalyzerEndpath'
   [2] Prefetching for module L1TGlobalSummary/'L1TGlobalSummary'
   [3] Prefetching for module L1TGlobalProducer/'simGtStage2Digis'
   [4] Prefetching for module L1TMuonProducer/'simGmtStage2Digis'
   [5] Prefetching for module L1TMuonOverlapPhase1TrackProducer/'simOmtfDigis'
   [6] Prefetching for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
   [7] Calling method for EventSetup module CSCL1TPLookupTableEP/''
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/SlopeCorrection/FacingChambers/CSCconsistency_2to1_SlopeShift_ME11a_even_layer1.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38830/26392/CMSSW_12_5_X_2022-07-21-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38830/26392/CMSSW_12_5_X_2022-07-21-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38830/26392/CMSSW_12_5_X_2022-07-21-2300/external/el8_amd64_gcc10/data:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/poison:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/src:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/external/el8_amd64_gcc10/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_mc_GRun
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 22-Jul-2022 10:58:29 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 3
   [1] Running path 'L1TAnalyzerEndpath'
   [2] Prefetching for module L1TGlobalSummary/'L1TGlobalSummary'
   [3] Prefetching for module L1TGlobalProducer/'simGtStage2Digis'
   [4] Prefetching for module L1TMuonProducer/'simGmtStage2Digis'
   [5] Prefetching for module L1TMuonOverlapPhase1TrackProducer/'simOmtfDigis'
   [6] Prefetching for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
   [7] Calling method for EventSetup module CSCL1TPLookupTableEP/''
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/SlopeCorrection/FacingChambers/CSCconsistency_2to1_SlopeShift_ME11a_even_layer1.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38830/26392/CMSSW_12_5_X_2022-07-21-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38830/26392/CMSSW_12_5_X_2022-07-21-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38830/26392/CMSSW_12_5_X_2022-07-21-2300/external/el8_amd64_gcc10/data:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/poison:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/src:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/external/el8_amd64_gcc10/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_mc_HIon
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 22-Jul-2022 10:58:29 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'L1TAnalyzerEndpath'
   [2] Prefetching for module L1TGlobalSummary/'L1TGlobalSummary'
   [3] Prefetching for module L1TGlobalProducer/'simGtStage2Digis'
   [4] Prefetching for module L1TMuonProducer/'simGmtStage2Digis'
   [5] Prefetching for module L1TMuonOverlapPhase1TrackProducer/'simOmtfDigis'
   [6] Prefetching for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
   [7] Calling method for EventSetup module CSCL1TPLookupTableEP/''
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/SlopeCorrection/FacingChambers/CSCconsistency_2to1_SlopeShift_ME11a_even_layer1.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38830/26392/CMSSW_12_5_X_2022-07-21-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38830/26392/CMSSW_12_5_X_2022-07-21-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38830/26392/CMSSW_12_5_X_2022-07-21-2300/external/el8_amd64_gcc10/data:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/poison:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/src:/cvmfs/cms-ib.cern.ch/nweek-02742/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-07-21-2300/external/el8_amd64_gcc10/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_mc_PIon
----- End Fatal Exception -------------------------------------------------
Expand to see more addon errors ...

@giovanni-mocellin
Copy link
Contributor

Hi all,
I see from the errors, that the issue you're having here are related to my recent PR (which is now merged, in fact).
If you want to do the tests with it included, you also need to include another PR from cms-data (which is now merged): cms-data/L1Trigger-CSCTriggerPrimitives#13

@kskovpen
Copy link
Contributor Author

Hi all,
I see from the errors, that the issue you're having here are related to my recent PR (which is now merged, in fact).
If you want to do the tests with it included, you also need to include another PR from cms-data (which is now merged): cms-data/L1Trigger-CSCTriggerPrimitives#13

Thanks a lot @giovanni-mocellin

@kskovpen
Copy link
Contributor Author

please test with cms-data/L1Trigger-CSCTriggerPrimitives#13

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89f107/26393/summary.html
COMMIT: 51292ce
CMSSW: CMSSW_12_5_X_2022-07-21-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38830/26393/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89f107/26393/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89f107/26393/git-merge-result

RelVals

----- Begin Fatal Exception 22-Jul-2022 12:58:28 CEST-----------------------
An exception of category 'ConditionsError' occurred while
   [0] Processing  Event run: 355442 lumi: 20 event: 33041904 stream: 0
   [1] Running path 'HLT_PPSMaxTracksPerRP4_v1'
   [2] Calling method for module L1TGlobalProducer/'hltGtStage2ObjectMap'
Exception Message:
 Error L1 menu loaded in via conditions does not match the L1 actually run 1135184612 vs 2016981387. This means that the mapping of the names to the bits may be incorrect. Please check the L1TUtmTriggerMenuRcd record supplied. Unless you know what you are doing, do not simply disable this check via the config as this a major error and the indication of something very wrong
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 22-Jul-2022 12:58:39 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://cms-xrd-global.cern.ch//store/data/Run2022B/MuonEG/RAW/v1/000/355/442/00000/b0887e84-3b2d-4402-bd2c-cd8517e7143e.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/data/Run2022B/MuonEG/RAW/v1/000/355/442/00000/b0887e84-3b2d-4402-bd2c-cd8517e7143e.root
      [b] Input file root://cms-xrd-global.cern.ch//store/data/Run2022B/MuonEG/RAW/v1/000/355/442/00000/b0887e84-3b2d-4402-bd2c-cd8517e7143e.root could not be opened.
      [c] XrdCl::File::Open(name='root://cms-xrd-global.cern.ch//store/data/Run2022B/MuonEG/RAW/v1/000/355/442/00000/b0887e84-3b2d-4402-bd2c-cd8517e7143e.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.
' (errno=3011, code=400). No additional data servers were found.
      [d] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/data/Run2022B/MuonEG/RAW/v1/000/355/442/00000/b0887e84-3b2d-4402-bd2c-cd8517e7143e.root?tried=&xrdcl.requuid=d5aeef88-f026-448e-9c96-526c3a2f488b
      [e] Problematic data server: cms-xrd-global.cern.ch:1094
      [f] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 22-Jul-2022 12:58:39 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://cms-xrd-global.cern.ch//store/data/Run2022B/Tau/RAW/v1/000/355/442/00000/0ab1613c-2005-4d2a-82a1-c4ebc441263e.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/data/Run2022B/Tau/RAW/v1/000/355/442/00000/0ab1613c-2005-4d2a-82a1-c4ebc441263e.root
      [b] Input file root://cms-xrd-global.cern.ch//store/data/Run2022B/Tau/RAW/v1/000/355/442/00000/0ab1613c-2005-4d2a-82a1-c4ebc441263e.root could not be opened.
      [c] XrdCl::File::Open(name='root://cms-xrd-global.cern.ch//store/data/Run2022B/Tau/RAW/v1/000/355/442/00000/0ab1613c-2005-4d2a-82a1-c4ebc441263e.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.
' (errno=3011, code=400). No additional data servers were found.
      [d] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/data/Run2022B/Tau/RAW/v1/000/355/442/00000/0ab1613c-2005-4d2a-82a1-c4ebc441263e.root?tried=&xrdcl.requuid=d74f1217-ac0c-4f45-8f95-82f0c5703cbd
      [e] Problematic data server: cms-xrd-global.cern.ch:1094
      [f] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

RelVals-INPUT

@kskovpen
Copy link
Contributor Author

@giovanni-mocellin do you know if there is some other PR to include in these tests to deal with the problems reported in 140.105?

@tvami
Copy link
Contributor

tvami commented Jul 22, 2022

@kskovpen that doesnt seem connected. Giovanni changed things for CSS-GEM. This issue now is PPS

@elfontan @panoskatsoulis can you maybe comment on the issue with the L1T menu

An exception of category 'ConditionsError' occurred while
   [0] Processing  Event run: 355442 lumi: 20 event: 33041904 stream: 0
   [1] Running path 'HLT_PPSMaxTracksPerRP4_v1'
   [2] Calling method for module L1TGlobalProducer/'hltGtStage2ObjectMap'
Exception Message:
 Error L1 menu loaded in via conditions does not match the L1 actually run 1135184612 vs 2016981387. This means that the mapping of the names to the bits may be incorrect. Please check the L1TUtmTriggerMenuRcd record supplied. Unless you know what you are doing, do not simply disable this check via the config as this a major error and the indication of something very wrong

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38830/31272

@cmsbuild
Copy link
Contributor

Pull request #38830 was updated. @jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please check and sign again.

@kskovpen
Copy link
Contributor Author

test parameters:

  • workflows = 140.001,140.002,140.103,140.104,140.105,140.106,140.113,140.114,140.115,140.116,140.117,140.107,140.108,140.109,140.110,140.111,140.112
  • relvals_opt = -w standard

@kskovpen
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89f107/26457/summary.html
COMMIT: d11ee2f
CMSSW: CMSSW_12_5_X_2022-07-25-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38830/26457/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89f107/140.001_RunMinimumBias2022B+RunMinimumBias2022B+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89f107/140.002_RunZeroBias2022B+RunZeroBias2022B+HLTRUN3+RECONANORUN3+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89f107/140.103_RunSingleMuon2022B+RunSingleMuon2022B+HLTRUN3+RECONANORUN3+SKIMSINGLEMUONRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89f107/140.104_RunZeroBias2022B+RunZeroBias2022B+HLTRUN3+RECONANORUN3+SKIMZEROBIASRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89f107/140.105_RunBTagMu2022B+RunBTagMu2022B+HLTRUN3+RECONANORUN3+SKIMBTAGMURUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89f107/140.106_RunJetHT2022B+RunJetHT2022B+HLTRUN3+RECONANORUN3+SKIMJETHTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89f107/140.107_RunDisplacedJet2022B+RunDisplacedJet2022B+HLTRUN3+RECONANORUN3+SKIMDISPLACEDJETRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89f107/140.108_RunMET2022B+RunMET2022B+HLTRUN3+RECONANORUN3+SKIMMETRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89f107/140.109_RunEGamma2022B+RunEGamma2022B+HLTRUN3+RECONANORUN3+SKIMEGAMMARUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89f107/140.111_RunDoubleMuon2022B+RunDoubleMuon2022B+HLTRUN3+RECONANORUN3+SKIMDOUBLEMUONRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89f107/140.112_RunMuonEG2022B+RunMuonEG2022B+HLTRUN3+RECONANORUN3+SKIMMUONEGRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89f107/140.113_RunNoBPTX2022B+RunNoBPTX2022B+HLTRUN3+RECONANORUN3+SKIMNOBPTXRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89f107/140.114_RunHcalNZS2022B+RunHcalNZS2022B+HLTRUN3+RECONANORUN3+SKIMHCALNZSRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89f107/140.115_RunHLTPhysics2022B+RunHLTPhysics2022B+HLTRUN3+RECONANORUN3+SKIMHLTPHYSICSRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89f107/140.116_RunCommissioning2022B+RunCommissioning2022B+HLTRUN3+RECONANORUN3+SKIMCOMMISSIONINGRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89f107/140.117_RunCosmics2022B+RunCosmics2022B+HLTRUN3+RECOCOSMRUN3+SKIMCOSMICSRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89f107/140.11_RunTau2022B+RunTau2022B+HLTRUN3+RECONANORUN3+SKIMTAURUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3667670
  • DQMHistoTests: Total failures: 20
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3667628
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 210 log files, 47 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@kskovpen
Copy link
Contributor Author

@srimanob you are welcome to sign :)

@srimanob
Copy link
Contributor

OK, now seems we are in good shape.

I think one clarification should be done is that will we have cosmics datasets in pp collision? And will the skim is need there? Where should this be clarified? In the joint meeting? However, that can be done beyond this PR. I would suggest at the moment, take it out from Tier-0. @tvami @kskovpen

@srimanob
Copy link
Contributor

+Upgrade

This PR adds RUN-3 skim workflows to runTheMatrix. All added workflows pass the PR test. One remaining question on cosmics with pp skim, to be followed up.

@tvami
Copy link
Contributor

tvami commented Jul 26, 2022

Where should this be clarified? In the joint meeting?

I think that's a good place for it, ORM this week is @mdmorris , please be sure the PdmV and DDT is present at the meeting.

I would suggest at the moment, take it out from Tier-0.

Given that it causes no problems for now, I'd say we should do this when the HLT menu changes and the merger happens, so we'll need to modify the config anyway.

Anyway, the final plan should be discussed on Friday and the ORM should follow up on the results of the discussion

@srimanob
Copy link
Contributor

Seem to be a good plan to move, thanks.

@kskovpen
Copy link
Contributor Author

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@kskovpen
Copy link
Contributor Author

@cms-sw/orp-l2 please consider merging this PR so that we could proceed with the backport to 12_4

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 580c410 into cms-sw:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants