-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wfs to test Run3 skims #38830
Add wfs to test Run3 skims #38830
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38830/31202
|
A new Pull Request was created by @kskovpen for master. It involves the following packages:
@jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
please test |
-1 Failed Tests: RelVals RelVals-INPUT AddOn The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: RelVals
Expand to see more relval errors ...
RelVals-INPUTAddOn Tests
Expand to see more addon errors ... |
Hi all, |
Thanks a lot @giovanni-mocellin |
please test with cms-data/L1Trigger-CSCTriggerPrimitives#13 |
-1 Failed Tests: RelVals RelVals-INPUT The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: RelVals
RelVals-INPUT |
@giovanni-mocellin do you know if there is some other PR to include in these tests to deal with the problems reported in 140.105? |
@kskovpen that doesnt seem connected. Giovanni changed things for CSS-GEM. This issue now is PPS @elfontan @panoskatsoulis can you maybe comment on the issue with the L1T menu
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38830/31272
|
Pull request #38830 was updated. @jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please check and sign again. |
test parameters:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89f107/26457/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
@srimanob you are welcome to sign :) |
OK, now seems we are in good shape. I think one clarification should be done is that will we have cosmics datasets in pp collision? And will the skim is need there? Where should this be clarified? In the joint meeting? However, that can be done beyond this PR. I would suggest at the moment, take it out from Tier-0. @tvami @kskovpen |
+Upgrade This PR adds RUN-3 skim workflows to runTheMatrix. All added workflows pass the PR test. One remaining question on cosmics with pp skim, to be followed up. |
I think that's a good place for it, ORM this week is @mdmorris , please be sure the PdmV and DDT is present at the meeting.
Given that it causes no problems for now, I'd say we should do this when the HLT menu changes and the merger happens, so we'll need to modify the config anyway. Anyway, the final plan should be discussed on Friday and the ORM should follow up on the results of the discussion |
Seem to be a good plan to move, thanks. |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@cms-sw/orp-l2 please consider merging this PR so that we could proceed with the backport to 12_4 |
+1 |
PR description:
Add Run3 skims to the standard relval wfs. The following wfs are added: 140.103-140.118.
PR validation:
Tested on the aforementioned wfs. At the moment, the wfs that run on 2022B (140.105, 140.110, 140.112, 140.113, 140.117, 140.118) will fail in the tests because of the issue at the HLT step. Maybe @cms-sw/hlt-l2 will have an idea what is wrong with the configuration (HLT:relval2022 is used, which should correspond to GRun) when using 2022B data. Alternatively, we can switch to fake HLT when testing these wfs.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR will be back ported to 12_4_X.
FYI: @sam7k9621 @cms-sw/alca-l2 @bbilin @rappoccio @jmartinb