Add Run-3 JECs to Run-3 MCs #38567

tvami · 2022-06-30T11:38:33Z

PR description:

This PR adds the new Run-3 JECs to Run-3 MCs as requested in cmsTalk https://cms-talk.web.cern.ch/t/gt-request-a-gt-for-run3-jec-tags-for-mc/12306

I created

124X_mcRun3_2022_realistic_v8
124X_mcRun3_2022cosmics_realistic_deco_v9
124X_mcRun3_2022_realistic_HI_v8
124X_mcRun3_2023_realistic_v9
124X_mcRun3_2024_realistic_v9
124X_mcRun4_realistic_v8

The diffs are
phase1_2022_realistic

https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun3_2022_realistic_v7/124X_mcRun3_2022_realistic_v8

phase1_2022_cosmics

https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun3_2022cosmics_realistic_deco_v8/124X_mcRun3_2022cosmics_realistic_deco_v9

phase1_2022_realistic_hi

https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun3_2022_realistic_HI_v7/124X_mcRun3_2022_realistic_HI_v8

phase1_2023_realistic

https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun3_2023_realistic_v6/124X_mcRun3_2023_realistic_v9

phase1_2024_realistic

https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun3_2024_realistic_v6/124X_mcRun3_2024_realistic_v9

phase2_realistic

https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun4_realistic_v7/124X_mcRun4_realistic_v8

PR validation:

test parameters:
  - workflows = 12034.0,11634.0,7.23,159.0,12434.0,12834.0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will be backported to 12_4_X

cmsbuild · 2022-06-30T11:46:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38567/30816

This PR adds an extra 12KB to repository

cmsbuild · 2022-06-30T11:47:09Z

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@tocheng, @Martin-Grunewald, @missirol, @mmusich, @ChrisMisan, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

tvami · 2022-06-30T11:48:47Z

test parameters:

workflows = 12034.0,11634.0,7.23,159.0,12434.0,12834.0

tvami · 2022-06-30T11:48:58Z

type jetmet

tvami · 2022-06-30T11:50:24Z

@cmsbuild , please test

cmsbuild · 2022-06-30T13:11:08Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-acc404/25914/summary.html
COMMIT: 91df1de
CMSSW: CMSSW_12_5_X_2022-06-29-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38567/25914/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-acc404/25914/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-acc404/25914/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

RelVals

136.8523

----- Begin Fatal Exception 30-Jun-2022 14:20:10 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_NANO_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/ParticleNetAK8/MassRegression/V01/modelfile/model.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38567/25914/CMSSW_12_5_X_2022-06-29-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38567/25914/CMSSW_12_5_X_2022-06-29-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38567/25914/CMSSW_12_5_X_2022-06-29-2300/external/el8_amd64_gcc10/data:/cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/src:/cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/external/el8_amd64_gcc10/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.8523_RunJetHT2018C_nanoULremini+RunJetHT2018C_nanoULremini+NANOEDM2018_106Xv2+HARVESTNANOAOD2018_106Xv2


At:
  /cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/src/FWCore/ParameterSet/python/Types.py(840): insertInto
  /cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/src/FWCore/ParameterSet/python/Mixins.py(376): insertContentsInto
  /cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/src/FWCore/ParameterSet/python/Mixins.py(511): insertInto
  /cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/src/FWCore/ParameterSet/python/Config.py(1199): _insertManyInto
  /cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/src/FWCore/ParameterSet/python/Config.py(1465): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

136.7611

----- Begin Fatal Exception 30-Jun-2022 14:20:35 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_PAT_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/ParticleNetAK4/CHS/V00/modelfile/model.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38567/25914/CMSSW_12_5_X_2022-06-29-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38567/25914/CMSSW_12_5_X_2022-06-29-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38567/25914/CMSSW_12_5_X_2022-06-29-2300/external/el8_amd64_gcc10/data:/cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/src:/cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/external/el8_amd64_gcc10/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM


At:
  /cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/src/FWCore/ParameterSet/python/Types.py(840): insertInto
  /cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/src/FWCore/ParameterSet/python/Mixins.py(376): insertContentsInto
  /cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/src/FWCore/ParameterSet/python/Mixins.py(511): insertInto
  /cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/src/FWCore/ParameterSet/python/Config.py(1199): _insertManyInto
  /cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/src/FWCore/ParameterSet/python/Config.py(1465): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

136.8311

----- Begin Fatal Exception 30-Jun-2022 14:20:35 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_PAT_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/ParticleNetAK4/CHS/V00/modelfile/model.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38567/25914/CMSSW_12_5_X_2022-06-29-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38567/25914/CMSSW_12_5_X_2022-06-29-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38567/25914/CMSSW_12_5_X_2022-06-29-2300/external/el8_amd64_gcc10/data:/cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/src:/cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/external/el8_amd64_gcc10/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017


At:
  /cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/src/FWCore/ParameterSet/python/Types.py(840): insertInto
  /cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/src/FWCore/ParameterSet/python/Mixins.py(376): insertContentsInto
  /cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/src/FWCore/ParameterSet/python/Mixins.py(511): insertInto
  /cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/src/FWCore/ParameterSet/python/Config.py(1199): _insertManyInto
  /cvmfs/cms-ib.cern.ch/nweek-02739/el8_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-06-29-2300/src/FWCore/ParameterSet/python/Config.py(1465): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

4.64.6_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1/step2_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1.log
136.72411136.72411_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM.log
136.72412136.72412_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM+HARVESTDR2_REMININANO_data2016UL_HIPM/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM+HARVESTDR2_REMININANO_data2016UL_HIPM.log

Expand to see more relval errors ...

tvami · 2022-06-30T13:15:11Z

The errors are completely unrelated... @cms-sw/orp-l2 is this known?

qliphy · 2022-06-30T13:26:39Z

The errors are completely unrelated... @cms-sw/orp-l2 is this known?

It seems the test is accompanied with the just merged PR #37964
but IB (CMSSW_12_5_X_2022-06-29-2300) probably is still building with cms-sw/cmsdist#7969
Let's wait a bit to retrigger the test.

tvami · 2022-06-30T13:27:45Z

I think we can just merge this PR as it is (no need to retrigger tests), there are no errors connected to the GT change, what do you think @cms-sw/alca-l2 ?

perrotta · 2022-06-30T13:32:39Z

This was tested with CMSSW_12_5_X_2022-06-29-2300 as baseline, adding #37964 on top of it, but not the needed data files merged in cmsdist and only available in CMSSW_12_5_X_2022-06-30-1100
The new release is now available, let retrigger the tests: I see no reason tu hurry up witj this

perrotta · 2022-06-30T13:32:48Z

please test

cmsbuild · 2022-06-30T18:03:50Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-acc404/25918/summary.html
COMMIT: 91df1de
CMSSW: CMSSW_12_5_X_2022-06-30-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38567/25918/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@dinyar Fix bug in muon index bit computation #38532

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-acc404/25918/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-acc404/25918/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-acc404/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-acc404/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

No significant changes to the logs found
Reco comparison results: 4270 differences found in the comparisons
DQMHistoTests: Total files compared: 54
DQMHistoTests: Total histograms compared: 4117638
DQMHistoTests: Total failures: 17498
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4100118
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
Checked 227 log files, 45 edm output root files, 54 DQM output files
TriggerResults: no differences found

malbouis · 2022-06-30T18:54:22Z

+alca

tests pass
all failures seem consistent with a change in the jet energy correction.

cmsbuild · 2022-06-30T18:54:45Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-06-30T19:33:50Z

+1

Add Run-3 JECs to Run-3 MCs

cmsbuild added this to the CMSSW_12_5_X milestone Jun 30, 2022

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Jun 30, 2022

Add Run-3 JECs to Run-3 MCs

91df1de

tvami force-pushed the Run3MCJECs branch from 860f06d to 91df1de Compare June 30, 2022 11:40

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 30, 2022

tvami marked this pull request as ready for review June 30, 2022 11:48

cmsbuild added the jetmet label Jun 30, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 30, 2022

cmsbuild added tests-rejected and removed tests-started labels Jun 30, 2022

cmsbuild added tests-started and removed tests-rejected labels Jun 30, 2022

cmsbuild added tests-approved and removed tests-started labels Jun 30, 2022

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Jun 30, 2022

cmsbuild added orp-approved and removed orp-pending labels Jun 30, 2022

cmsbuild merged commit b656633 into cms-sw:master Jun 30, 2022

cmsbuild mentioned this pull request Jul 1, 2022

[llvm] Update to version 14.0.6 cms-sw/cmsdist#7729

Closed

tvami mentioned this pull request Jul 1, 2022

[12_4_X] Add Run-3 JECs to Run-3 MCs #38578

Merged

nickh2000 pushed a commit to nickh2000/cmssw that referenced this pull request Jul 20, 2022

Merge pull request cms-sw#38567 from tvami/Run3MCJECs

a826c95

Add Run-3 JECs to Run-3 MCs

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Run-3 JECs to Run-3 MCs #38567

Add Run-3 JECs to Run-3 MCs #38567

tvami commented Jun 30, 2022 •

edited

Loading

cmsbuild commented Jun 30, 2022

cmsbuild commented Jun 30, 2022

tvami commented Jun 30, 2022

tvami commented Jun 30, 2022

tvami commented Jun 30, 2022

cmsbuild commented Jun 30, 2022

tvami commented Jun 30, 2022

qliphy commented Jun 30, 2022

tvami commented Jun 30, 2022 •

edited

Loading

perrotta commented Jun 30, 2022

perrotta commented Jun 30, 2022

cmsbuild commented Jun 30, 2022

malbouis commented Jun 30, 2022

cmsbuild commented Jun 30, 2022

perrotta commented Jun 30, 2022

Add Run-3 JECs to Run-3 MCs #38567

Add Run-3 JECs to Run-3 MCs #38567

Conversation

tvami commented Jun 30, 2022 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Jun 30, 2022

cmsbuild commented Jun 30, 2022

tvami commented Jun 30, 2022

tvami commented Jun 30, 2022

tvami commented Jun 30, 2022

cmsbuild commented Jun 30, 2022

Unit Tests

RelVals

RelVals-INPUT

tvami commented Jun 30, 2022

qliphy commented Jun 30, 2022

tvami commented Jun 30, 2022 • edited Loading

perrotta commented Jun 30, 2022

perrotta commented Jun 30, 2022

cmsbuild commented Jun 30, 2022

Comparison Summary

malbouis commented Jun 30, 2022

cmsbuild commented Jun 30, 2022

perrotta commented Jun 30, 2022

tvami commented Jun 30, 2022 •

edited

Loading

tvami commented Jun 30, 2022 •

edited

Loading