Geant4 technical updates #38542

civanch · 2022-06-28T14:43:10Z

PR description:

Several changes in Geant4 simulation:

improved verbatim printouts on start/stop of Geant4
moved end of run Geant4 UI commands from master thread to worker threads
improved low-energy GFlash method

Mainstream results should not be changed.

PR validation:

private

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: NO

cmsbuild · 2022-06-28T14:56:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38542/30777

This PR adds an extra 36KB to repository

cmsbuild · 2022-06-28T14:56:44Z

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/Application (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @bsunanda, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

civanch · 2022-06-28T14:58:02Z

please test

cmsbuild · 2022-06-28T18:46:13Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd85aa/25872/summary.html
COMMIT: 37d4e18
CMSSW: CMSSW_12_5_X_2022-06-28-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38542/25872/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3654586
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3654556
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: no differences found

civanch · 2022-06-29T08:02:39Z

+1

cmsbuild · 2022-06-29T08:03:04Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-06-29T12:22:44Z

SimG4Core/Application/plugins/OscarMTProducer.cc

@@ -103,6 +103,7 @@ namespace {
 OscarMTProducer::OscarMTProducer(edm::ParameterSet const& p, const OscarMTMasterThread* ms)
    : m_handoff{p.getUntrackedParameter<int>("workerThreadStackSize", 10 * 1024 * 1024)} {
  m_verbose = p.getParameter<int>("EventVerbose");
+  //  m_G4CommandsEndRun(p.getParameter<std::vector<std::string> >("G4CommandsEndRun")),


This commented out line can get removed, as far as I can see

perrotta · 2022-06-29T12:25:28Z

SimG4Core/Application/src/LowEnergyFastSimModel.cc

@@ -68,7 +68,7 @@ void LowEnergyFastSimModel::DoIt(const G4FastTrack& fastTrack, G4FastStep& fastS
  fastStep.KillPrimaryTrack();
  fastStep.SetPrimaryTrackPathLength(0.0);
  auto track = fastTrack.GetPrimaryTrack();
-  G4double energy = track->GetKineticEnergy();
+  G4double energy = track->GetKineticEnergy() * 1.015;


Where this factor 1.015 comes from?
Define at least a constexpr value which defines it?

perrotta · 2022-06-29T12:32:02Z

3. improved low-energy GFlash method

Mainstream results should not be changed.

Could you please elaborate? The GFlash improvement only deals with code optimization? This line makes me think the opposite...
And by the way, which are the "non mainstream" results which get changed instead

civanch · 2022-06-29T14:32:11Z

@perrotta , thanks for comments, will address them. Concerning "mainstream": this GFlash method can be used if is enabled, it was used for private validations only (where from 1.015 appears), we plan introduce this method in 13_0 after validation.

cmsbuild · 2022-06-29T14:47:09Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38542/30792

This PR adds an extra 36KB to repository

cmsbuild · 2022-06-29T14:47:30Z

Pull request #38542 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

perrotta · 2022-06-29T15:01:10Z

please test

cmsbuild · 2022-06-29T18:51:12Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd85aa/25887/summary.html
COMMIT: bfcb36a
CMSSW: CMSSW_12_5_X_2022-06-29-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38542/25887/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3654586
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3654562
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: no differences found

civanch · 2022-06-30T07:45:20Z

+1

cmsbuild · 2022-06-30T07:45:40Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-06-30T08:39:07Z

+1

civanch added 2 commits June 28, 2022 16:16

Updated start/stop of Geant4 run

0eaa1be

code-format

86621fa

cmsbuild added this to the CMSSW_12_5_X milestone Jun 28, 2022

cmsbuild added code-checks-pending orp-pending pending-signatures simulation-pending tests-pending labels Jun 28, 2022

restore back stacking action

37d4e18

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 28, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 28, 2022

cmsbuild added tests-approved and removed tests-started labels Jun 28, 2022

cmsbuild added fully-signed simulation-approved and removed simulation-pending pending-signatures labels Jun 29, 2022

perrotta reviewed Jun 29, 2022

View reviewed changes

address comments

bfcb36a

cmsbuild removed the simulation-approved label Jun 29, 2022

cmsbuild added code-checks-pending pending-signatures simulation-pending tests-pending and removed fully-signed tests-approved code-checks-approved labels Jun 29, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 29, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 29, 2022

cmsbuild added tests-approved and removed tests-started labels Jun 29, 2022

cmsbuild added fully-signed simulation-approved and removed simulation-pending pending-signatures labels Jun 30, 2022

cmsbuild added orp-approved and removed orp-pending labels Jun 30, 2022

cmsbuild merged commit 3b20114 into cms-sw:master Jun 30, 2022

cmsbuild mentioned this pull request Jun 30, 2022

Add Run-3 JECs to Run-3 MCs #38567

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Geant4 technical updates #38542

Geant4 technical updates #38542

civanch commented Jun 28, 2022

cmsbuild commented Jun 28, 2022

cmsbuild commented Jun 28, 2022

civanch commented Jun 28, 2022

cmsbuild commented Jun 28, 2022

civanch commented Jun 29, 2022

cmsbuild commented Jun 29, 2022

perrotta Jun 29, 2022

perrotta Jun 29, 2022

perrotta commented Jun 29, 2022

civanch commented Jun 29, 2022

cmsbuild commented Jun 29, 2022

cmsbuild commented Jun 29, 2022

perrotta commented Jun 29, 2022

cmsbuild commented Jun 29, 2022

civanch commented Jun 30, 2022

cmsbuild commented Jun 30, 2022

perrotta commented Jun 30, 2022

Geant4 technical updates #38542

Geant4 technical updates #38542

Conversation

civanch commented Jun 28, 2022

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: NO

cmsbuild commented Jun 28, 2022

cmsbuild commented Jun 28, 2022

civanch commented Jun 28, 2022

cmsbuild commented Jun 28, 2022

Comparison Summary

civanch commented Jun 29, 2022

cmsbuild commented Jun 29, 2022

perrotta Jun 29, 2022

Choose a reason for hiding this comment

perrotta Jun 29, 2022

Choose a reason for hiding this comment

perrotta commented Jun 29, 2022

civanch commented Jun 29, 2022

cmsbuild commented Jun 29, 2022

cmsbuild commented Jun 29, 2022

perrotta commented Jun 29, 2022

cmsbuild commented Jun 29, 2022

Comparison Summary

civanch commented Jun 30, 2022

cmsbuild commented Jun 30, 2022

perrotta commented Jun 30, 2022