-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix range in recHitsEndcapsPosXY #38326
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38326/30504
|
A new Pull Request was created by @silviodonato (Silvio Donato) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type bug-fix |
@cmsbuild , please test |
type trk |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b34a8/25440/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
During a fast track validation of HLT of a global tag @elfontan and @swagata87 found the error [1]
which complains that the range of
recHitsEndcapsPosXY
changed between the lumisections.Looking at the code, the bug is evident and the bug fix is very trivial.
[1]
PR validation:
Very trivial bug fix, I admit no validation...
if this PR is a backport please specify the original PR and why you need to backport that PR:
We will need a backport down to 12_3_X for the data taking