Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skim for Delayed Jets, MET cut instead of HT #37808

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Conversation

rtschmitz
Copy link

PR description:

This PR adds one RECO level skim that saves all standard AOD collections. This PR is similar to PR#37509, which added a skim over delayed jets using a set of HLT paths, except this skim uses a cut on MET rather than on HT. It does this using the producer/filter for delayed jets in CMSSW and skimming over the HLT path "HLT_PFMET120_PFMHT120_IDTight_v*".

Tested with high-Pt QCD samples /store/relval/CMSSW_12_3_0_pre6/RelValQCD_Pt_1800_2400_14/GEN-SIM-RECO/123X_mcRun3_2021_realistic_v11-v2/, the skimmed AOD file size was 25MB (68 events) and the unskimmed AOD file size was 1.9GB (9000 events).

PR validation:

Ran with CMSSW_12_4_0_pre1 and used the config file "test_DelayedJetMET_cfg.py" which is included in this PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37808/29726

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2022

A new Pull Request was created by @rtschmitz for master.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@cmsbuild, @bbilin, @kskovpen, @jordan-martins can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@rtschmitz
Copy link
Author

One additional comment I wanted to make: This PR is complementary to PR#37749, which provides a general MET>200 skim. This skim lowers the MET threshold for delayed jets to MET>120.

@smuzaffar smuzaffar modified the milestones: CMSSW_12_4_X, CMSSW_12_5_X May 16, 2022
@kskovpen
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8c7b6/25411/summary.html
COMMIT: e48264c
CMSSW: CMSSW_12_5_X_2022-06-09-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37808/25411/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3658678
  • DQMHistoTests: Total failures: 19
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3658636
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Jun 10, 2022

+1

@cmsbuild cmsbuild merged commit 11a6a68 into cms-sw:master Jun 10, 2022
paths = (EXODelayedJetMETPath),
content = skimRawAODContent.outputCommands,
selectEvents = cms.untracked.PSet(),
dataTier = cms.untracked.string('AOD')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this really supposed to have been an AOD? @sam7k9621 @davidlange6 @rappoccio

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the analysis needs access to the ecal rechits that are only available in AOD

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other skims use USER, right? @sam7k9621 @davidlange6 @rappoccio please comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply.
I think it can remain ‘AOD’ since there is no customized event content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants